1306241 - Use NeedsSubjectPrincipal in dom/html/*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: explicit_principal7.patch

Comment 1

[Andrea Marchesini [:baku]]

Attachment: explicit_principal8.patch

Comment 2

[(no longer active)]

Comment on attachment 8796075 [details] [diff] [review]
explicit_principal7.patch

Review of attachment 8796075 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDocument.cpp
@@ +6256,5 @@
>  {
>    ErrorResult rv;
> +  nsIDocument::LoadBindingDocument(aURI,
> +                                   nsContentUtils::GetCurrentJSContext()
> +                                     ? Some(nsContentUtils::SubjectPrincipal())

Can we remove this?

::: dom/html/nsGenericHTMLFrameElement.cpp
@@ +79,5 @@
>  nsGenericHTMLFrameElement::GetContentDocument(nsIDOMDocument** aContentDocument)
>  {
>    NS_PRECONDITION(aContentDocument, "Null out param");
> +  nsCOMPtr<nsIDOMDocument> document =
> +    do_QueryInterface(GetContentDocument(Some(nsContentUtils::SubjectPrincipal())));

Can we remove this?

::: dom/html/nsHTMLDocument.cpp
@@ +2836,3 @@
>  {
>    ErrorResult rv;
> +  SetDesignMode(aDesignMode, Some(nsContentUtils::SubjectPrincipal()), rv);

Can we remove this?

Comment 3

[(no longer active)]

Comment on attachment 8796099 [details] [diff] [review]
explicit_principal8.patch

Review of attachment 8796099 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLObjectElement.cpp
@@ +465,5 @@
>  {
>    NS_ENSURE_ARG_POINTER(aContentDocument);
>  
> +  nsCOMPtr<nsIDOMDocument> domDoc =
> +    do_QueryInterface(GetContentDocument(Some(nsContentUtils::SubjectPrincipal())));

Can we remove this?

Comment 4

[Andrea Marchesini [:baku]]

> >    ErrorResult rv;
> > +  SetDesignMode(aDesignMode, Some(nsContentUtils::SubjectPrincipal()), rv);
> 
> Can we remove this?

No, we cannot.

For the others, I'll check in a follow up.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dffc1cba16eb
Use NeedsSubjectPrincipal in dom/html/* - part 1, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/98bcafb5ec2c
Use NeedsSubjectPrincipal in dom/html/* - part 2, r=ehsan

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dffc1cba16eb
https://hg.mozilla.org/mozilla-central/rev/98bcafb5ec2c

Comment 7

[Eric Shepherd [:sheppy]]

This doesn’t appear to impact web developers, instead being an implementation detail. Is that the case?

Comment 8

[Andrea Marchesini [:baku]]

Yes. No impact to web developers.