Closed Bug 1306241 Opened 3 years ago Closed 3 years ago

Use NeedsSubjectPrincipal in dom/html/*

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

No description provided.
Attachment #8796075 - Flags: review?(ehsan)
Attachment #8796099 - Flags: review?(ehsan)
Comment on attachment 8796075 [details] [diff] [review]
explicit_principal7.patch

Review of attachment 8796075 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDocument.cpp
@@ +6256,5 @@
>  {
>    ErrorResult rv;
> +  nsIDocument::LoadBindingDocument(aURI,
> +                                   nsContentUtils::GetCurrentJSContext()
> +                                     ? Some(nsContentUtils::SubjectPrincipal())

Can we remove this?

::: dom/html/nsGenericHTMLFrameElement.cpp
@@ +79,5 @@
>  nsGenericHTMLFrameElement::GetContentDocument(nsIDOMDocument** aContentDocument)
>  {
>    NS_PRECONDITION(aContentDocument, "Null out param");
> +  nsCOMPtr<nsIDOMDocument> document =
> +    do_QueryInterface(GetContentDocument(Some(nsContentUtils::SubjectPrincipal())));

Can we remove this?

::: dom/html/nsHTMLDocument.cpp
@@ +2836,3 @@
>  {
>    ErrorResult rv;
> +  SetDesignMode(aDesignMode, Some(nsContentUtils::SubjectPrincipal()), rv);

Can we remove this?
Attachment #8796075 - Flags: review?(ehsan) → review+
Comment on attachment 8796099 [details] [diff] [review]
explicit_principal8.patch

Review of attachment 8796099 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLObjectElement.cpp
@@ +465,5 @@
>  {
>    NS_ENSURE_ARG_POINTER(aContentDocument);
>  
> +  nsCOMPtr<nsIDOMDocument> domDoc =
> +    do_QueryInterface(GetContentDocument(Some(nsContentUtils::SubjectPrincipal())));

Can we remove this?
Attachment #8796099 - Flags: review?(ehsan) → review+
> >    ErrorResult rv;
> > +  SetDesignMode(aDesignMode, Some(nsContentUtils::SubjectPrincipal()), rv);
> 
> Can we remove this?

No, we cannot.

For the others, I'll check in a follow up.
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dffc1cba16eb
Use NeedsSubjectPrincipal in dom/html/* - part 1, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/98bcafb5ec2c
Use NeedsSubjectPrincipal in dom/html/* - part 2, r=ehsan
https://hg.mozilla.org/mozilla-central/rev/dffc1cba16eb
https://hg.mozilla.org/mozilla-central/rev/98bcafb5ec2c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
This doesn’t appear to impact web developers, instead being an implementation detail. Is that the case?
Flags: needinfo?(amarchesini)
Yes. No impact to web developers.
Flags: needinfo?(amarchesini)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.