1306248 - Use NeedsSubjectPrincipal in DOMStorage

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: explicit_principal9.patch

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99817b61d70
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan

Comment 2

[Iris Hsiao [:ihsiao]]

Backed out for crashed @ nsContentUtils::SubjectPrincipal, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=36903225&repo=mozilla-inbound#L1146

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9a069260d72
Backed out changeset a99817b61d70 for crashed @nsContentUtils::SubjectPrincipal

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8bf0eea94
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/caa8bf0eea94

Comment 6

[Jean-Yves Perrier [:teoli]]

I'm evaluating if this change in the WebIDL needs dev docs, but I'm not able to find any info about the NeedsSubjectPrincipal extended attribute. What does it do?

[Adding ddn on this bug and similar to keep track of them, if needed]

Comment 7

[Andrea Marchesini [:baku]]

No, the use/functionality of the API is untouched.
We have to introduce NeedsSubjectPrincipal in https://developer.mozilla.org/en/Mozilla/WebIDL_bindings

Comment 8

[(no longer active)]

(In reply to Andrea Marchesini [:baku] from comment #7)
> We have to introduce NeedsSubjectPrincipal in
> https://developer.mozilla.org/en/Mozilla/WebIDL_bindings

Can you please do that?  :-)  I meant to ask you before but I forgot...

Comment 9

[Andrea Marchesini [:baku]]

Done. Please, take a look.

Comment 10

[(no longer active)]

Looks great, thank you!

Comment 11

[Jean-Yves Perrier [:teoli]]

Marking this as complete then ;-)