Use NeedsSubjectPrincipal in DOMStorage

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

({dev-doc-complete})

50 Branch
mozilla52
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8796110 [details] [diff] [review]
explicit_principal9.patch
Attachment #8796110 - Flags: review?(ehsan)

Updated

2 years ago
Attachment #8796110 - Flags: review?(ehsan) → review+

Comment 1

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99817b61d70
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan

Comment 2

2 years ago
Backed out for crashed @ nsContentUtils::SubjectPrincipal, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=36903225&repo=mozilla-inbound#L1146
Flags: needinfo?(amarchesini)

Comment 3

2 years ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9a069260d72
Backed out changeset a99817b61d70 for crashed @nsContentUtils::SubjectPrincipal
(Assignee)

Updated

2 years ago
Flags: needinfo?(amarchesini)

Comment 4

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8bf0eea94
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/caa8bf0eea94
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
I'm evaluating if this change in the WebIDL needs dev docs, but I'm not able to find any info about the NeedsSubjectPrincipal extended attribute. What does it do?

[Adding ddn on this bug and similar to keep track of them, if needed]
Flags: needinfo?(amarchesini)
Keywords: dev-doc-needed
(Assignee)

Comment 7

2 years ago
No, the use/functionality of the API is untouched.
We have to introduce NeedsSubjectPrincipal in https://developer.mozilla.org/en/Mozilla/WebIDL_bindings
Flags: needinfo?(amarchesini)

Comment 8

2 years ago
(In reply to Andrea Marchesini [:baku] from comment #7)
> We have to introduce NeedsSubjectPrincipal in
> https://developer.mozilla.org/en/Mozilla/WebIDL_bindings

Can you please do that?  :-)  I meant to ask you before but I forgot...
Flags: needinfo?(amarchesini)
(Assignee)

Comment 9

2 years ago
Done. Please, take a look.
Flags: needinfo?(amarchesini)

Comment 10

2 years ago
Looks great, thank you!
Marking this as complete then ;-)
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.