Closed
Bug 1306248
Opened 8 years ago
Closed 8 years ago
Use NeedsSubjectPrincipal in DOMStorage
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
15.88 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8796110 -
Flags: review?(ehsan)
Updated•8 years ago
|
Attachment #8796110 -
Flags: review?(ehsan) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a99817b61d70 Use NeedsSubjectPrincipal in DOMStorage, r=ehsan
Comment 2•8 years ago
|
||
Backed out for crashed @ nsContentUtils::SubjectPrincipal, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=36903225&repo=mozilla-inbound#L1146
Flags: needinfo?(amarchesini)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c9a069260d72 Backed out changeset a99817b61d70 for crashed @nsContentUtils::SubjectPrincipal
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8bf0eea94 Use NeedsSubjectPrincipal in DOMStorage, r=ehsan
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/caa8bf0eea94
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 6•8 years ago
|
||
I'm evaluating if this change in the WebIDL needs dev docs, but I'm not able to find any info about the NeedsSubjectPrincipal extended attribute. What does it do? [Adding ddn on this bug and similar to keep track of them, if needed]
Flags: needinfo?(amarchesini)
Keywords: dev-doc-needed
Assignee | ||
Comment 7•8 years ago
|
||
No, the use/functionality of the API is untouched. We have to introduce NeedsSubjectPrincipal in https://developer.mozilla.org/en/Mozilla/WebIDL_bindings
Flags: needinfo?(amarchesini)
Comment 8•8 years ago
|
||
(In reply to Andrea Marchesini [:baku] from comment #7) > We have to introduce NeedsSubjectPrincipal in > https://developer.mozilla.org/en/Mozilla/WebIDL_bindings Can you please do that? :-) I meant to ask you before but I forgot...
Flags: needinfo?(amarchesini)
Comment 10•8 years ago
|
||
Looks great, thank you!
Comment 11•8 years ago
|
||
Marking this as complete then ;-)
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•