Closed Bug 1306248 Opened 3 years ago Closed 3 years ago

Use NeedsSubjectPrincipal in DOMStorage

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Attachment #8796110 - Flags: review?(ehsan)
Attachment #8796110 - Flags: review?(ehsan) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99817b61d70
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan
Backed out for crashed @ nsContentUtils::SubjectPrincipal, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=36903225&repo=mozilla-inbound#L1146
Flags: needinfo?(amarchesini)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9a069260d72
Backed out changeset a99817b61d70 for crashed @nsContentUtils::SubjectPrincipal
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8bf0eea94
Use NeedsSubjectPrincipal in DOMStorage, r=ehsan
https://hg.mozilla.org/mozilla-central/rev/caa8bf0eea94
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
I'm evaluating if this change in the WebIDL needs dev docs, but I'm not able to find any info about the NeedsSubjectPrincipal extended attribute. What does it do?

[Adding ddn on this bug and similar to keep track of them, if needed]
Flags: needinfo?(amarchesini)
Keywords: dev-doc-needed
No, the use/functionality of the API is untouched.
We have to introduce NeedsSubjectPrincipal in https://developer.mozilla.org/en/Mozilla/WebIDL_bindings
Flags: needinfo?(amarchesini)
(In reply to Andrea Marchesini [:baku] from comment #7)
> We have to introduce NeedsSubjectPrincipal in
> https://developer.mozilla.org/en/Mozilla/WebIDL_bindings

Can you please do that?  :-)  I meant to ask you before but I forgot...
Flags: needinfo?(amarchesini)
Done. Please, take a look.
Flags: needinfo?(amarchesini)
Looks great, thank you!
Marking this as complete then ;-)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.