Closed Bug 1306296 Opened 5 years ago Closed 5 years ago

Missing shortcut key to Simplify Page

Categories

(Toolkit :: Printing, defect, P2)

Product:
Toolkit
Component:
Printing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 --- affected
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: bogdan_maris, Assigned: leandromanica)

Details

Attachments

(2 files)

Screenshot showing the issue
14.27 KB, image/png
Details
Add simplify page keyboard shortcut
2.14 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
[Affected versions]:
- Firefox 50 beta 2
- latest Nightly 52.0a1

[Affected platforms]:
- Windows 7 64 bit
- Windows 10 64 bit
- Ubuntu 16.04 32 bit and 64 bit

[Steps to reproduce]:
1. Start Firefox
2. Visit a page with Reader View (ex: wikipedia.org)
3. Go to File -> Print Preview

[Expected result]:
- Simplify Page has a shortcut key that can be accessed via keyboard

[Actual result]:
- Shortcut key missing from Simplify Page.

[Regression range]:
- This is not a recent regression, it reproduces on the old Nightly from 2016-06-06 where Simplify page was introduced. 

[Additional notes]:
- Screenshot showing the issue attached
Probably should add this for a11y. mlongaray, do you know anybody at HP who'd want to take this on? I could try to mentor.
Flags: needinfo?(mlongaray)
Priority: -- → P2
That would be great, Mike! leandromanica, are you willing to take this one?
Flags: needinfo?(mlongaray) → needinfo?(leandromanica)
Yes. Can you assign me, mconley?

I already have a working patch, so you can give a first look.
Flags: needinfo?(leandromanica) → needinfo?(mconley)
Happy to, thank you Leandro.
Assignee: nobody → leandromanica
Flags: needinfo?(mconley)
This patch adds a keyboard shortcut to simplify page while in print preview.
Attachment #8801221 - Flags: review?(mconley)
Comment on attachment 8801221 [details] [diff] [review]
Add simplify page keyboard shortcut

Looks good to me! Thanks!
Attachment #8801221 - Flags: review?(mconley) → review+
Author: Leandro Manica <leandromanica@hp.com>
Bug number: 1306296
Commit message: "Bug 1306296 - Add shortcut key to Simplify Page feature. r=mconley"
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a26cfff8041b
Add shortcut key to Simplify Page feature. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a26cfff8041b
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.