1306308 - [One-off searches] Awesomebar results don't show the correct search engine when searching with search engine keywords

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Liviu Cirdei]

Attachment: screenshot_of_the_issue.jpg

[Affected versions]:
Nightly 52.0a1 Build ID 20160928030201

[Affected platforms]:
All (Windows 10, Mac 10.12, Ubuntu 16.04)
 
[Steps to reproduce]:
1. Open Firefox with a new profile.
2. Go to about:preferences#search.
3. Add a keyword for one search engine(e.g for Bing add "bn" keyword).
4. In Awesomebar type the keyword from step 3 and a search term (e.g "bn mozilla").
5. Inspect the results from the dropdown.

[Expected result]:
 Results from Awesomebar should state that the search will be performed with "Bing" (e.g. "mozilla - Search with Bing").
 
[Actual result]
 Results from Awesomebar state that the search will be performed with Google even if the search is performed with Bing. Note that the Bing icon is present, just the text seems to be wrong.

[Regression Range]
Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=46045ec8a4aa09a341b7209170089ade3c27c1a5&tochange=555caa0082c342c60830261ecba4c4068122207e

Regressed by bug 1180944.

Comment 1

[Drew Willcoxon :adw]

Question to figure out: does this affect Aurora too or only Nightly?

Comment 2

[Liviu Cirdei]

I was surprised to see this, but it affects Aurora too, even if the preference for on-off-searches is turned off.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1306308 - [One-off searches] Awesomebar results don't show the correct search engine when searching with search engine keywords.

Review commit: https://reviewboard.mozilla.org/r/86200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86200/

Comment 4

[Drew Willcoxon :adw]

urlbar's overrideSearchEngineName is too defensive.  It should not return an engine name when there is no selected one-off button because it will clobber searchengines embedded in mozactions as in this case.

Comment 5

[Drew Willcoxon :adw]

(In reply to Liviu Cirdei [:liviucirdei] from comment #2)
> I was surprised to see this, but it affects Aurora too, even if the
> preference for on-off-searches is turned off.

I can see how it might be surprising, but the one-off searches work touched quite a bit of the underlying urlbar and autocomplete code, even though the final user-facing result is preffed off.  So it's possible there are other non-Nightly regressions -- hopefully not! :-)

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8801451 [details]
Bug 1306308 - [One-off searches] Awesomebar results don't show the correct search engine when searching with search engine keywords.

https://reviewboard.mozilla.org/r/86200/#review85280

::: browser/base/content/urlbarBindings.xml:1696
(Diff revision 1)
>        <!-- Result listitems call this to determine which search engine they
>             should show in their labels and include in their url attributes. -->
>        <property name="overrideSearchEngineName" readonly="true">
>          <getter><![CDATA[
> -          // When building the popup, autocomplete reuses an item at index i if
> -          // that item's url attribute matches the controller's value at index
> +          let button = this.oneOffSearchButtons.selectedButton;
> +          return button && button.engine ? button.engine.name : null;

return button && button.engine && button.engine.name;

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8801451 [details]
Bug 1306308 - [One-off searches] Awesomebar results don't show the correct search engine when searching with search engine keywords.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86200/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ef1bb323867
[One-off searches] Awesomebar results don't show the correct search engine when searching with search engine keywords. r=mak

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ef1bb323867

Comment 10

[Drew Willcoxon :adw]

Attachment: Aurora 51 patch

Approval Request Comment
[Feature/regressing bug #]:
One-off searches in the urlbar, bug 1180944. That feature is disabled on non-Nightly, but its supporting code changes are shipping on all branches starting in 51, and they caused this regression.

[User impact if declined]:
Search engine keywords can't be used from the urlbar

[Describe test coverage new/current, TreeHerder]:
Manually tested

[Risks and why]:
Low risk, very tiny and straightforward patch

[String/UUID change made/needed]:
None

Comment 11

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #10)
> [User impact if declined]:
> Search engine keywords can't be used from the urlbar

Sorry, they *work* correctly, they just aren't *shown* right in the urlbar popup.  e.g., the popup will say "Search with Google" when it should say "Search with Bing"

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8802343 [details] [diff] [review]
Aurora 51 patch

Fix a regression related to awesomebar. Take it in 51 aurora.

Comment 13

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 52.0a1 (2016-09-29) (64-bit) on Windows 7  , 64 Bit !

This bug's fix is verified with latest Nightly 

Build ID    : 20161019030208
User Agent  : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161019]

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef8ca0453519

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef8ca0453519

Comment 16

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID 	20161020004015
Version 	51.0a2

The fix is also verified on Aurora 51. 
I tested on Windows 10, Mac 10.11 and Ubuntu 16.04.