1306315 - Rename Send Tab action extension so that it's identifiable as a Firefox feature

Status: NEW

(Firefox for iOS :: Browser, defect, P3)

Description

[Ryan Feeley [:rfeeley]]

Attachment: send-to-firefox-ios.png

Send to Device is coming soon to a browser eco-system near you, and with Push and the Devices API it will be terrific, terrific.  Currently our Send Tab option is listed alongside other options in the share extension menu without any reference to Firefox.

Please include the Firefox name as depicted so that users will know that it's not referring to another browser or service.

Comment 1

[Stephan Leroux [:sleroux]]

James, I remember you were working on a related bug and there was some kind of issue with localization. Do you recall that bug?

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Steph, this was the bug you had in mind: https://bugzilla.mozilla.org/show_bug.cgi?id=1277500 .

Comment 3

[Stefan Plewako [:stef]]

(In reply to Ryan Feeley [:rfeeley] from comment #0)
> Created attachment 8796184 [details]
> send-to-firefox-ios.png

This change affects only Activities management screen or also things like share menu?

> Send to Device is coming soon to a browser eco-system near you, and with
> Push and the Devices API it will be terrific, terrific.  Currently our Send
> Tab option is listed alongside other options in the share extension menu
> without any reference to Firefox.

Is this accurate? In share extension menu we have Firefox icons and only in share extension management we don't have reference to Firefox.

I'm asking because with proposed changes we might be unable to fit with translated string.
(en-US grows from 8 to 17 characters, pl would probably need 30)

Comment 4

[Alex Davis [:adavis]]

With Send Tab and push landing in Firefox 7 for iOS, is this string change something easy enough that we could do on time to make sure that users understand the feature better?

Comment 5

[Richard Newman [:rnewman]]

Re-nomming so Alex's question gets answered.


> Is this accurate? In share extension menu we have Firefox icons and only in
> share extension management we don't have reference to Firefox.

I can confirm that both View Later and Send Tab in the iOS share screen appear with huge Firefox icons.

It is unfortunate that the management screen and the space-limited UI both use exactly the same strings.

For comparison, DropBox uses "Save to Dropbox". Other similar strings are "Send to Camera+", "Add to iCloud Drive".

The reason we didn't use "Send to Firefox" in the first place, years ago, is because it's not clear what that means: you have Firefox on your iPhone, so is this tweet going to open on your phone or somewhere else?

We *could* address that by adding "View Later" *inside* Send to Firefox, which clarifies the ambiguity. But that's more than just a string change.


> I'm asking because with proposed changes we might be unable to fit with
> translated string.
> (en-US grows from 8 to 17 characters, pl would probably need 30)

There are two lines available if we really need them: we fit "Request Desktop Site" in en_US, which is 20 characters, and we could likely fit 24.

Comment 6

[Emily Toop (:fluffyemily)]

Attachment: WIP

I am no longer able to work on this. Here is a WIP branch of everything I have done so far.

Comment 7

[Jacob White]

Attachment: Pull Request

Comment 8

[Emily Toop (:fluffyemily)]

Attachment: ExtensionsList.png

This isn't exactly right. It works great for View Later, but as you can see in the attached image, Sent Tab is being displayed as CFBundleDisplayName.

Comment 9

[Jacob White]

Does it work if you do a clean install?

Comment 10

[Emily Toop (:fluffyemily)]

(In reply to Jacob White from comment #9)
> Does it work if you do a clean install?

No, that screenshot came from a clean install that I did after I couldn't find `Send Tab to fennec(emilytoop)` on the upgrade path.

Comment 11

[Jacob White]

Ok

Comment 12

[Jacob White]

Attachment: Pull Request

Ok, this is working for me with all 3 extensions.