Closed Bug 1306447 Opened 4 years ago Closed 4 years ago

Remove b2g-specific code from WebExtensions

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're committed to removing b2g-specific code from mozilla-central, so there's no need to keep around the special cases that are cluttering up the WebExtensions tree.
Comment on attachment 8796301 [details]
Bug 1306447: Remove b2g support code from WebExtensions.

https://reviewboard.mozilla.org/r/82194/#review80872

I didn't go hunting for anything that may have been overlooked but this all seems good assuming try is happy of course.

::: toolkit/components/extensions/test/mochitest/mochitest.ini
(Diff revision 1)
>  [DEFAULT]
> -skip-if = buildapp == 'mulet' || asan

starting to run these under asan is unrelated to b2g isn't it?  (i don't have an opinion on whether we should or not, just want to make sure this wasn't inadvertent)
Attachment #8796301 - Flags: review?(aswan) → review+
Blocks: nukeb2g
Comment on attachment 8796301 [details]
Bug 1306447: Remove b2g support code from WebExtensions.

https://reviewboard.mozilla.org/r/82194/#review80872

> starting to run these under asan is unrelated to b2g isn't it?  (i don't have an opinion on whether we should or not, just want to make sure this wasn't inadvertent)

Yes, it was intentional. It was supposed to be removed with bug 1207911, but wasn't. It's not technically related, though.
https://hg.mozilla.org/mozilla-central/rev/cdb240a81e9b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Duplicate of this bug: 1222312
No longer blocks: 1369194
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.