Closed Bug 1306497 Opened 3 years ago Closed 3 years ago

Crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java)

Categories

(Core :: Widget: Android, defect, P1, critical)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: kats, Assigned: droeh)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-5acb2a49-9a07-468f-9f4d-c52e32160929.
=============================================================
Nightly is crashing even while not running.
Assignee: nobody → droeh
Blocks: 1294821
Keywords: regression
This patch just checks if the GeckoInterface or instance EventDispatcher is null, and skips dispatching to the instance EventDispatcher in that case.
Attachment #8796599 - Flags: review?(nchen)
Comment on attachment 8796599 [details] [diff] [review]
handleGeckoMessage null-checking

Review of attachment 8796599 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
@@ +1954,5 @@
> +        if (getGeckoInterface() != null && getGeckoInterface().getAppEventDispatcher() != null) {
> +            success = EventDispatcher.getInstance().dispatchEvent(message) |
> +                      getGeckoInterface().getAppEventDispatcher().dispatchEvent(message);
> +        } else {
> +            success = EventDispatcher.getInstance().dispatchEvent(message);

Just do,

> boolean success = ...;
> if (...) {
>     success |= ...;
> }

@@ +1956,5 @@
> +                      getGeckoInterface().getAppEventDispatcher().dispatchEvent(message);
> +        } else {
> +            success = EventDispatcher.getInstance().dispatchEvent(message);
> +        }
> +        

nit: extra space in blank line
Attachment #8796599 - Flags: review?(nchen) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a08af19f3b3c
Check that the GeckoInterface and instance EventDispatcher are non-null before dispatching events. r=jchen
Priority: -- → P1
This is the most annoying bug ever. I'm just using random other apps and I get the nightly crash reporter dialog interrupting me. I had to downgrade to an older nightly just to get anything done.
https://hg.mozilla.org/mozilla-central/rev/a08af19f3b3c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.