1306497 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

This bug was filed from the Socorro interface and is 
report bp-5acb2a49-9a07-468f-9f4d-c52e32160929.
=============================================================
Nightly is crashing even while not running.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: handleGeckoMessage null-checking

This patch just checks if the GeckoInterface or instance EventDispatcher is null, and skips dispatching to the instance EventDispatcher in that case.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8796599 [details] [diff] [review]
handleGeckoMessage null-checking

Review of attachment 8796599 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
@@ +1954,5 @@
> +        if (getGeckoInterface() != null && getGeckoInterface().getAppEventDispatcher() != null) {
> +            success = EventDispatcher.getInstance().dispatchEvent(message) |
> +                      getGeckoInterface().getAppEventDispatcher().dispatchEvent(message);
> +        } else {
> +            success = EventDispatcher.getInstance().dispatchEvent(message);

Just do,

> boolean success = ...;
> if (...) {
>     success |= ...;
> }

@@ +1956,5 @@
> +                      getGeckoInterface().getAppEventDispatcher().dispatchEvent(message);
> +        } else {
> +            success = EventDispatcher.getInstance().dispatchEvent(message);
> +        }
> +        

nit: extra space in blank line

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a08af19f3b3c
Check that the GeckoInterface and instance EventDispatcher are non-null before dispatching events. r=jchen

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This is the most annoying bug ever. I'm just using random other apps and I get the nightly crash reporter dialog interrupting me. I had to downgrade to an older nightly just to get anything done.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a08af19f3b3c