130650 - In page info, "Security" tab lacks shortcut.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Jaagup Irve]

In Mozilla 0.9.9's page info, "Security" tab lacks underlined shortcut key while
the other tabs have one.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To page info.  None of the shortcuts seem to work in any case...

Comment 2

[Aaron Leventhal]

The accesskey's don't work because of bug 128608 - Accesskeys don't work for
(xul) tabpanels

Comment 3

[Daniel Brooks [:db48x]]

-> PSM, client library. anything and everything related to the security tab
comes from a seperate overlay.

Comment 4

[Stephen Walker]

Attachment: patch

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 76485 [details] [diff] [review]
patch

r=kaie

Comment 6

[jag (Peter Annema)]

Comment on attachment 76485 [details] [diff] [review]
patch

>Index: mozilla/security/manager/pki/resources/locale/en-US/PageInfoOverlay.dtd
>===================================================================
>RCS file: /cvsroot/mozilla/security/manager/pki/resources/locale/en-US/PageInfoOverlay.dtd,v
>retrieving revision 1.2
>diff -u -r1.2 PageInfoOverlay.dtd
>--- mozilla/security/manager/pki/resources/locale/en-US/PageInfoOverlay.dtd	2001/05/03 00:41:10	1.2
>+++ mozilla/security/manager/pki/resources/locale/en-US/PageInfoOverlay.dtd	2002/03/28 00:44:08
>@@ -20,7 +20,8 @@
>    -   Terry Hayes <[e-mail]>
>   -->
> 
>-<!ENTITY  pageInfo.securityTab    "Security">
>+<!ENTITY  pageInfo.securityTab    "Security">

I can't see anything having changed, so I suspect it's whitespace added to the
end of the line.
If you're adding spaces there, can you remove them?

>+<!ENTITY  pageInfo.accesskey      "s">
> <!ENTITY  pageInfo.securityHeader "Security information for this page">
> <!ENTITY  pageInfo.view.label     "View">

>-
>+

Same for this change

sr=jag

Comment 7

[Stephen Walker]

jag, the extra lines aren't spaces, but places where the file had DOS line 
endings.

Comment 8

[jag (Peter Annema)]

Ah, cool, thanks for fixing that. So has this been checked in yet?

Comment 9

[Kai Engert [:KaiE:]]

Let me know if you want me to check this in.

Comment 10

[Kai Engert [:KaiE:]]

taking

Comment 11

[Kai Engert [:KaiE:]]

Checked in to trunk, fixed.

Comment 12

[John Unruh]

Verified code checked into 5/29 Win2000 trunk in en-US.jar, PageInfoOverlay.dtd 

Comment 13

[Kai Engert [:KaiE:]]

A question, do those shortcuts actually work? When I try on Linux, I could not
find out how to open any tab using the shortcut key.

Comment 14

[jag (Peter Annema)]

See comment 1.

Comment 15

[John Unruh]

How about an nsbeta1+?

Comment 16

[Kai Engert [:KaiE:]]

If those shortcuts are indeed not yet working anywhere, I think it's not
required to land this on the branch.

Comment 17

[John Unruh]

Verified.