1306505 - [webvr] Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation

Status: RESOLVED FIXED

(Core :: WebVR, defect, P3)

Description

[:kip (Kearwood Gilbert)]

Content from separate iframes, separate tabs, or separate windows should not be able to exit a VR presentation with VRDisplay.exitPresent unless it was the content that started the presentation with VRDisplay.beginPresent.

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

Review commit: https://reviewboard.mozilla.org/r/123330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123330/

Comment 2

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8850812 [details]
Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

https://reviewboard.mozilla.org/r/123330/#review125714

::: dom/vr/test/test_vrDisplay_exitPresent.html:21
(Diff revision 1)
> +            return content.vrDisplay.exitPresent();
> +        });
> +      }
> +      var initVRPresentation = function(content) {
> +            return content.navigator.getVRDisplays().then((displays) => {
> +            console.log("GetVRDisplay!!");

Please remove console.log

::: dom/vr/test/test_vrDisplay_exitPresent.html:33
(Diff revision 1)
> +      function startTest() {
> +        var ifr1 = document.getElementById("iframe1");
> +        var ifr2 = document.getElementById("iframe2");
> +        var frame1 = ifr1.contentWindow;
> +        var frame2 = ifr2.contentWindow;
> +        initVRPresentation(frame1).then(() => {

You should confirm the vrdisplay from iframe 1 is isPresenting and then start to check iframe 2 whether it is available to present.

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8850812 [details]
Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123330/diff/1-2/

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8850812 [details]
Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123330/diff/2-3/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8850812 [details]
Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

https://reviewboard.mozilla.org/r/123330/#review125786

LGTM. Please make sure getting the green lights from try before landing.

Comment 6

[Michael Leu[:Lenzak](UTC+8)]

Here is try result, anything other than green light seems to have nothing to do with it. 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e326c4b97a6d92ef216d3ecaf4d2e02423888a&selectedJob=86154057

Comment 7

[Daosheng Mu[:daoshengmu]]

Please don't forget to have a try on Android.

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a5ffd72900ac8aac41d21b70b98723cad0a4b6

Here is try result with Android, looks OK.

Comment 9

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 2 changes to 2 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 6faedea20076 needs "Bug N" or "No bug" in the commit message.
remote: Chih-Yi Leu <[e-mail]>
remote: Bug1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation; r=daoshengmu
remote: 
remote: MozReview-Commit-ID: 8iFE4vK4oiZ
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote

Comment 10

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8850812 [details]
Bug 1306505 - Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123330/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16e182457e16
Implement mochitest: VRDisplay.exitPresent must only be allowed by content that started VR Presentation; r=daoshengmu

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16e182457e16