1306588 - Make Pulse jobs ingestion gracefully handle jobs for unknown repositories

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Description

[Ed Morley [:emorley]]

Currently job_loader.py does:

        for project, job_list in validated_jobs.items():
            with JobsModel(project) as jobs_model:

...which I think means it will raise DatasetNotFoundError if the job is for an unknown repository, and then go on to retry 10 times.

Should we add a try-except and instead log?

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:unknown-repo-gracefully > mozilla:master

Comment 2

[Ed Morley [:emorley]]

Ping for my question here:
https://github.com/mozilla/treeherder/pull/1895#discussion_r82301550

Comment 3

[Cameron Dawson [:camd]]

Ed: yeah, you're right.  And this code changed a fair bit since the ORM changes went in.  Fixed this up now.

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8797795 [details] [review]
[treeherder] mozilla:unknown-repo-gracefully > mozilla:master

Thanks for the ping on this.  :)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8797795 [details] [review]
[treeherder] mozilla:unknown-repo-gracefully > mozilla:master

r+ with review comment addressed :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2b0ef8a6ddd1df50ec8a01e69d35324934e87afe
Bug 1306588 - Log unsupported repos for pulse jobs (#1895)