1306603 - TabChild::SetAPZChild is never called with a non-null APZChild

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

The patch at [1] removed a call to TabChild::SetAPZChild and didn't replace it with anything equivalent. So now it looks like TabChild::mAPZChild is always null, and so the code at [2] will never actually run. To be honest I'm not entirely sure if we still need that code but we should figure that out and then either remove it or fix it.

[1] https://hg.mozilla.org/mozilla-central/rev/b0d9956e1251
[2] http://searchfox.org/mozilla-central/rev/d1276b5b84e6cf7991c8e640b5e0ffffd54575a6/dom/ipc/TabChild.cpp#3014

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Kan-ru, do you know if the code added in bug 845169 is still needed on desktop or Fennec? Or was it specific to B2G?

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> Kan-ru, do you know if the code added in bug 845169 is still needed on
> desktop or Fennec? Or was it specific to B2G?

It was very specific to the B2G keyboard app. I don't think it's used anywhere else. I even think we can safely remove all mozpasspointerevents related code now.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Awesome, thanks! That will be some nice cleanup.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Try push with all the mozpasspointerevents code removed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49877f198ba7

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1306603 - Remove APZ code that uses the mozpasspointerevents update region.

Review commit: https://reviewboard.mozilla.org/r/82468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82468/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1306603 - Remove rest of mozpasspointerevents code as it is not needed any more.

Review commit: https://reviewboard.mozilla.org/r/82470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82470/

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8796716 [details]
Bug 1306603 - Remove APZ code that uses the mozpasspointerevents update region.

https://reviewboard.mozilla.org/r/82468/#review81366

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8796717 [details]
Bug 1306603 - Remove rest of mozpasspointerevents code as it is not needed any more.

https://reviewboard.mozilla.org/r/82470/#review82084

Hooray!

Comment 9

[Kartikaya Gupta (email:[e-mail])]

I realized that in part 1 I can also remove RemoteContentController::mMutex since it's only used to protect stuff that's being deleted now. So I took that out as well.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fef0ff55d14
Remove APZ code that uses the mozpasspointerevents update region. r=kanru
https://hg.mozilla.org/integration/mozilla-inbound/rev/9da2b89efdec
Remove rest of mozpasspointerevents code as it is not needed any more. r=kanru

Comment 11

[Kartikaya Gupta (email:[e-mail])]

No need to uplift this to 51 since the issue described in comment 0 isn't really a bug in 51.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fef0ff55d14
https://hg.mozilla.org/mozilla-central/rev/9da2b89efdec