1306624 - Add telemetry probe for when printing is initiated

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Matheus Longaray (:mlongaray)]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce:

I spoke to Mike Conley and laid out that we are still missing yet another telemetry probe.

1) When the user prints a document. This is a keyed histogram, with the following keys: printed from outside print preview, printed from within print preview, and printed a simplified document. Probe was landed in bug 1287587.
2) The user enters print preview. This is a normal count histogram, and was landed in bug 1275570.
3) The user simplifies a print preview. This is a normal count histogram, and was landed in bug 1275570.
4) The user enters print preview, but simplification is deemed not possible. Normal count histogram that was landed in bug 1287587.
5) When the user initiates a print operation. This is a keyed histogram, with the following keys: printing from outside print preview, and printing from within print preview.

So this bug is basically about adding (5).

Comment 1

[Thauã Silveira]

Attachment: WIP1: Add telemetry probe

This patch adds new telemetry probe that counts when the user opens print dialog.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8796685 [details] [diff] [review]
WIP1: Add telemetry probe

Review of attachment 8796685 [details] [diff] [review]:
-----------------------------------------------------------------

This looks okay to me, but going to request data-review from liuche.

::: toolkit/components/telemetry/Histograms.json
@@ +6262,5 @@
> +     "kind": "count",
> +     "keyed": true,
> +     "releaseChannelCollection": "opt-out",
> +     "description": "A counter incremented every time the user opens print dialog."
> +   },

Busted indentation here.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8796685 [details] [diff] [review]
WIP1: Add telemetry probe

Review of attachment 8796685 [details] [diff] [review]:
-----------------------------------------------------------------

Data-review only. This looks fine to me - it describes when this probe is measured, which is every time the print dialog is opened.

Comment 4

[Thauã Silveira]

Attachment: WIP2: Fix indentation

Small change as mconley suggested.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8798026 [details] [diff] [review]
WIP2: Fix indentation

Review of attachment 8798026 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Author: Thauã Silveira <[e-mail]>
Bug number: 1306624
Commit message:

"Bug 1306624 - Add telemetry probes to count how many times a user requests to print a document. r=mconley, data-review=liuche

This is distinct from the PRINT_COUNT probe, which counts how many times Gecko starts a print operation (which might not occur if the user cancels out of the print dialog)."

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee5506cde86
Add telemetry probes to count how many times a user requests to print a document. r=mconley, data-review=liuche

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1ee5506cde86

Comment 9

[Matheus Longaray (:mlongaray)]

Hey Mike, are we planning to uplift this one to Aurora & Beta as well?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Yes, I believe that makes sense.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8798026 [details] [diff] [review]
WIP2: Fix indentation

Approval Request Comment
[Feature/regressing bug #]:

Printing.

[User impact if declined]:

None.

[Describe test coverage new/current, TreeHerder]:

None.

[Risks and why]: 

Very low. This just adds a Telemetry probe that counts how many times the print dialog is displayed to the user. liuche did the data review.

[String/UUID change made/needed]:

None.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8798026 [details] [diff] [review]
WIP2: Fix indentation

This seems like a good telemetry probe to add. Aurora51+, Beta50+

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mike, going forward, for such uplifts, could you please mention whether we have verified that data is showing up on Nightly channel on the new probe and looks good? This help decide whether uplifting it is a good idea or not.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I checked the evo dashboard and on Nightly52, there have been submissions on PRINT_DIALOG_OPENED_COUNT probe since Oct 11th so we are good.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/684b31fa5cb1

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7106084ad63

Comment 17

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ritu Kothari (:ritu) from comment #13)
> Hi Mike, going forward, for such uplifts, could you please mention whether
> we have verified that data is showing up on Nightly channel on the new probe
> and looks good? This help decide whether uplifting it is a good idea or not.

Will do! Thanks!