add checkbox to page.cgi?id=query_database.html to dump results as csv instead of rendering html table

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: BMO
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
SSIA
(Assignee)

Comment 1

a year ago
Created attachment 8797646 [details] [diff] [review]
1306637_1.patch

low priority
Attachment #8797646 - Flags: review?(dylan)
Comment on attachment 8797646 [details] [diff] [review]
1306637_1.patch

Review of attachment 8797646 [details] [diff] [review]:
-----------------------------------------------------------------

I know we do token checking here, but can be make sure that a POST request is required?
Attachment #8797646 - Flags: review?(dylan) → review-
(Assignee)

Comment 3

a year ago
Created attachment 8802594 [details] [diff] [review]
1306637_2.patch
Attachment #8797646 - Attachment is obsolete: true
Attachment #8802594 - Flags: review?(dylan)
Comment on attachment 8802594 [details] [diff] [review]
1306637_2.patch

Review of attachment 8802594 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

fix nit on commit.

::: extensions/BMO/Extension.pm
@@ +2273,5 @@
>      my $query = $input->{query};
>      $vars->{query} = $query;
>  
> +    # Allow only POST requests
> +

nit: duplicate comment, remove
Attachment #8802594 - Flags: review?(dylan) → review+
(Assignee)

Comment 5

a year ago
To https://github.com/mozilla-bteam/bmo.git
   96fc28e..ee119fd  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.