Closed
Bug 1306637
Opened 9 years ago
Closed 9 years ago
add checkbox to page.cgi?id=query_database.html to dump results as csv instead of rendering html table
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file, 1 obsolete file)
|
5.31 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
SSIA
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8797646 [details] [diff] [review]
1306637_1.patch
Review of attachment 8797646 [details] [diff] [review]:
-----------------------------------------------------------------
I know we do token checking here, but can be make sure that a POST request is required?
Attachment #8797646 -
Flags: review?(dylan) → review-
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8797646 -
Attachment is obsolete: true
Attachment #8802594 -
Flags: review?(dylan)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8802594 [details] [diff] [review]
1306637_2.patch
Review of attachment 8802594 [details] [diff] [review]:
-----------------------------------------------------------------
r=dylan
fix nit on commit.
::: extensions/BMO/Extension.pm
@@ +2273,5 @@
> my $query = $input->{query};
> $vars->{query} = $query;
>
> + # Allow only POST requests
> +
nit: duplicate comment, remove
Attachment #8802594 -
Flags: review?(dylan) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
To https://github.com/mozilla-bteam/bmo.git
96fc28e..ee119fd master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•