Replace nsString with nsAString in nsLinebreakConverter::ConvertStringLineBreaks

RESOLVED FIXED

Status

()

Core
String
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: harishd, Assigned: Scott Collins)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
nsLinebreakConverter::ConvertStringLineBreaks() seems to accepting nsString. Could 
this be changed to nsAString ( or something equivalent ) instead? This blocks
bug 111576.
(Reporter)

Comment 1

17 years ago
Nominating for nsbeta1 since it blocks bug 111576.
Severity: normal → blocker
Keywords: nsbeta1
(Reporter)

Comment 2

17 years ago
After refering to lxr it looks like this bug should belong to sfraser.
Assignee: scc → sfraser

Updated

17 years ago
Severity: blocker → normal
Summary: Repleace nsString with nsAString → Replace nsString with nsAString
(Reporter)

Comment 3

17 years ago
timeless: Why did you change the severity from blocker to normal. THIS BUG
BLOCKS BUG 111576.
Severity: normal → blocker

Comment 4

17 years ago
if it blocks some bug, then use blocks/depends, blocker should be considered 
severity, and in my opinion this is nearly trivial.
Blocks: 111576

Updated

17 years ago
Summary: Replace nsString with nsAString → Replace nsString with nsAString in nsLinebreakConverter::ConvertStringLineBreaks

Comment 5

17 years ago
Timeless is right. 'Blocker' means that it prevents daily use. And how exactly
does this block bug 111576?
Severity: blocker → normal
OS: Windows 2000 → All
Hardware: PC → All
(Reporter)

Comment 6

17 years ago
Ok...my bad...my understanding for "blocker" was different. Now I know :)

Comment 7

17 years ago
reassigning to scc.
Assignee: sfraser → scc

Comment 8

17 years ago
"Reassign bug to owner and QA contact of selected component"
Assignee: scc → jaggernaut
QA Contact: jaggernaut → scc

Comment 9

17 years ago
Thanks timeless, but in this case he really meant "reassigning to scc"
Assignee: jaggernaut → scc
QA Contact: scc → jaggernaut
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 10

17 years ago
Created attachment 75923 [details]
a hard-wired line-ending conversion function for |nsAString|

This function can be pasted right into your source near the point where you
need it.  Still need to double-check if it's OK to directly say '\r' and '\n'
or if that gets screwed up under MacOS <= 9.  It's fine on Windows, *nix, and
MacOS X.

Hope this helps
(Assignee)

Comment 11

17 years ago
We might want to use some |PR...| type rather than |size_t| in the above patch.
 Let's talk about it when we paste this function into your _big_ patch.
(Assignee)

Comment 12

17 years ago
jag, the string owner, is going to look at the feasibility of replacing the
existing line break converter with this function, in which case, he'll end up
chopping it out of where ever you put it, and putting it someplace more global

Comment 13

16 years ago
this patch was checked in at the appropriate spot as part of the fix for bug 
#111576
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.