1306691 - Don't use easy_install

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Gregory Szorc [:gps]]

easy_install is old and essentially deprecated in favor of pip. We should not be using easy_install in 2016.

(This bug is a result of fallout noticed in bug 1304176.)

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1306691 - Remove references to pywin32 package;

pywin32 was removed as a requirement to run Talos in bug 726700,
~3 years ago. The references in mozharness were never updated,
apparently.

Review commit: https://reviewboard.mozilla.org/r/82434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82434/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1306691 - Remove support for easy_install;

Support for easy_install was added in bug 761809 as part of supporting
pywin32. We just removed support for pywin32. And there are no in-tree
consumers using the "easy_install" install method. Furthermore,
easy_install is effectively deprecated as a package install mechanism:
pip should always be used.

So, we remove support for easy_install from mozharness.

Review commit: https://reviewboard.mozilla.org/r/82436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82436/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1306691 - Remove install_method argument and uses;

Now that we've removed support for using easy_install, we no longer
need the "install_method" argument to specify how we want to install
packages since there is only one method: pip. So remove that code.

Review commit: https://reviewboard.mozilla.org/r/82438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82438/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8796667 [details]
Bug 1306691 - Remove references to pywin32 package;

https://reviewboard.mozilla.org/r/82434/#review81054

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8796668 [details]
Bug 1306691 - Remove support for easy_install;

https://reviewboard.mozilla.org/r/82436/#review81056

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8796669 [details]
Bug 1306691 - Remove install_method argument and uses;

https://reviewboard.mozilla.org/r/82438/#review81058

Nice patch series!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7d8bed34d87
Remove references to pywin32 package; r=ted
https://hg.mozilla.org/integration/autoland/rev/2a95fbb01ffe
Remove support for easy_install; r=ted
https://hg.mozilla.org/integration/autoland/rev/3aa78ab9fce9
Remove install_method argument and uses; r=ted

Comment 8

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/b0706e5d7ae3 - Windows mda has an explicit dependency on pywin32, https://treeherder.mozilla.org/logviewer.html#?job_id=4311965&repo=autoland

Comment 9

[Gregory Szorc [:gps]]

pywin32 isn't declared as a dependency anywhere in the tree. That's why I thought it was unused. Upon further examination, it looks like the failing test is downloading a ton of other Python packages and one of those has a dependency on pywin32.

Repeat after me: always use requirements files.

Fixing this could be "fun" since this test only has pip 0.8.2 installed, since I guess that's what the Windows testers have out of the box.

If it is just this one test job failing, I may just add a source checkout so it has access to modern virtualenv+pip versions.

Comment 10

[Gregory Szorc [:gps]]

I'm not actively working on this (sadly).

Comment 11

[Geoff Brown [:gbrown]]

Attachment: Bug 1306691 - Remove easy_install support from mozharness and upgrade pywin32

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0840e115fd3b
Remove easy_install support from mozharness and upgrade pywin32 r=jmaher

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0840e115fd3b