Status

defect
3 years ago
2 years ago

People

(Reporter: gps, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

easy_install is old and essentially deprecated in favor of pip. We should not be using easy_install in 2016.

(This bug is a result of fallout noticed in bug 1304176.)
Comment on attachment 8796667 [details]
Bug 1306691 - Remove references to pywin32 package;

https://reviewboard.mozilla.org/r/82434/#review81054
Attachment #8796667 - Flags: review?(ted) → review+
Comment on attachment 8796668 [details]
Bug 1306691 - Remove support for easy_install;

https://reviewboard.mozilla.org/r/82436/#review81056
Attachment #8796668 - Flags: review?(ted) → review+
Comment on attachment 8796669 [details]
Bug 1306691 - Remove install_method argument and uses;

https://reviewboard.mozilla.org/r/82438/#review81058

Nice patch series!
Attachment #8796669 - Flags: review?(ted) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7d8bed34d87
Remove references to pywin32 package; r=ted
https://hg.mozilla.org/integration/autoland/rev/2a95fbb01ffe
Remove support for easy_install; r=ted
https://hg.mozilla.org/integration/autoland/rev/3aa78ab9fce9
Remove install_method argument and uses; r=ted
pywin32 isn't declared as a dependency anywhere in the tree. That's why I thought it was unused. Upon further examination, it looks like the failing test is downloading a ton of other Python packages and one of those has a dependency on pywin32.

Repeat after me: always use requirements files.

Fixing this could be "fun" since this test only has pip 0.8.2 installed, since I guess that's what the Windows testers have out of the box.

If it is just this one test job failing, I may just add a source checkout so it has access to modern virtualenv+pip versions.
Flags: needinfo?(gps)
Depends on: 1307305
I'm not actively working on this (sadly).
Status: ASSIGNED → NEW
Flags: needinfo?(gps)
Assignee: gps → nobody
You need to log in before you can comment on or make changes to this bug.