1306717 - Mach command for mochitests ignores --manifest option

Status: RESOLVED FIXED

Description

[Dan Minor [:dminor]]

We reset the test manifest based upon the tests passed to the 'run_mochitest' function, for instance at [1]. A simple solution that works for my use case is to just make the condition:

if tests and not options.manifestFile:

But I'm open to better suggestions if anyone has any.

This is to support running WebRTC tests on Autophone rather than emulators. I would like to make it easy for people to run tests using the Autophone specific manifest files without having to have an Autophone setup available.

[1] https://dxr.mozilla.org/mozilla-central/rev/9baec74b3db1bf005c66ae2f50bafbdb02c3be38/testing/mochitest/mach_commands.py#268

Comment 1

[Dan Minor [:dminor]]

Created attachment 8797136 [details]
Bug 1306717 - Mach command for mochitests ignores --manifest option;

Review commit: https://reviewboard.mozilla.org/r/82754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82754/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8797136 [details]
Bug 1306717 - Mach command for mochitests ignores --manifest option;

https://reviewboard.mozilla.org/r/82754/#review81476

Lgtm, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c075dbe4e001
Mach command for mochitests ignores --manifest option; r=ahal

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c075dbe4e001