Closed Bug 1306717 Opened 4 years ago Closed 4 years ago

Mach command for mochitests ignores --manifest option

Categories

(Testing :: Mochitest, defect)

Version 3
defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

We reset the test manifest based upon the tests passed to the 'run_mochitest' function, for instance at [1]. A simple solution that works for my use case is to just make the condition:

if tests and not options.manifestFile:

But I'm open to better suggestions if anyone has any.

This is to support running WebRTC tests on Autophone rather than emulators. I would like to make it easy for people to run tests using the Autophone specific manifest files without having to have an Autophone setup available.

[1] https://dxr.mozilla.org/mozilla-central/rev/9baec74b3db1bf005c66ae2f50bafbdb02c3be38/testing/mochitest/mach_commands.py#268
Comment on attachment 8797136 [details]
Bug 1306717 - Mach command for mochitests ignores --manifest option;

https://reviewboard.mozilla.org/r/82754/#review81476

Lgtm, thanks!
Attachment #8797136 - Flags: review?(ahalberstadt) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c075dbe4e001
Mach command for mochitests ignores --manifest option; r=ahal
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c075dbe4e001
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.