Closed Bug 1306782 Opened 5 years ago Closed 5 years ago

Remove B2G from WebRTC mochitests

Categories

(Core :: WebRTC, defect, P2)

52 Branch
Unspecified
Gonk (Firefox OS)
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
backlog: --- → webrtc/webaudio+
Rank: 25
Comment on attachment 8796771 [details]
Bug 1306782: remove B2G from WebRTC mochitest.ini.

https://reviewboard.mozilla.org/r/82510/#review81364

LGTM

::: dom/media/tests/mochitest/mochitest.ini:51
(Diff revision 1)
>  [test_getUserMedia_basicVideo.html]
> -skip-if = (toolkit == 'gonk' || buildapp == 'mulet' && debug) # debug-only failure
>  [test_getUserMedia_basicVideo_playAfterLoadedmetadata.html]
> -skip-if = (toolkit == 'gonk' || buildapp == 'mulet' && debug) # debug-only failure
>  [test_getUserMedia_basicScreenshare.html]
> -skip-if = buildapp == 'b2g' || toolkit == 'android' # no screenshare on b2g/android # Bug 1141029 Mulet parity with B2G Desktop for TC
> +skip-if = toolkit == 'android' # no screenshare on android # Bug 1141029 Mulet parity with B2G Desktop for TC

Please remove the Mulet bug number here and for the next two bugs as well.

Do we have a bug on file for no window sharing on Android that we could mention here, or that never planned to be supported?

::: dom/media/tests/mochitest/mochitest.ini:113
(Diff revision 1)
>  [test_peerConnection_basicVideo.html]
> -skip-if = toolkit == 'gonk' || buildapp == 'mulet' || (android_version == '18' && debug) # b2g(Bug 960442, video support for WebRTC is disabled on b2g), android(Bug 1189784, timeouts on 4.3 emulator)
> +skip-if = (android_version == '18' && debug) # android(Bug 1189784, timeouts on 4.3 emulator)
>  [test_peerConnection_basicScreenshare.html]
> -# no screenshare on b2g/android
> +# no screenshare on android
>  # frequent timeouts/crashes on e10s (bug 1048455)
> -skip-if = buildapp == 'b2g' || buildapp == 'mulet' || toolkit == 'android' # Bug 1141029 Mulet parity with B2G Desktop for TC
> +skip-if = toolkit == 'android' # Bug 1141029 Mulet parity with B2G Desktop for TC

Please remove the Mulet bug number here and for the next two bugs.
Attachment #8796771 - Flags: review?(dminor) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/935121aed27e
remove B2G from WebRTC mochitest.ini. r=dminor
Maire do we have any plans for screenshare on Android?
Flags: needinfo?(mreavy)
https://hg.mozilla.org/mozilla-central/rev/935121aed27e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(In reply to Nils Ohlmeier [:drno] from comment #5)
> Maire do we have any plans for screenshare on Android?

We have no plans for it.  I can see someone wanting it in the future, at which point we'd prioritize it.  There may be a bug on file for Android screensharing somewhere in the bug database, but at this point I'd prioritize such a bug as a P5 or even parking-lot.
Flags: needinfo?(mreavy)
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.