1306859 - Make &bugfiler the default for is_staff

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Phil Ringnalda (:philor)]

It gets old, having to edit the URL every single time you open a tab, and then consider whether to re-edit it every time you paste a URL somewhere.

Comment 1

[Ed Morley [:emorley]]

I'd be open to enabling it by default for everyone, though Wes can have the final say :-)

Comment 2

[Phil Ringnalda (:philor)]

I'm pretty strongly opposed to making it available to everyone all the time. We've already seen multiple times that its pull is too strong for even sheriffs who should know better to resist, and had permaorange filed as an intermittent and merged around and happily starred as a permaorange intermittent for hours, and even with the need for a little knowledge and a little copy-paste to manually file, we have seen developers file their own bustage as an intermittent and get away with it for a while. I don't think our need to have everyone file intermittents is great enough to balance out how tempting it is to just file anything when you can do it with two clicks.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:bug1306859 > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8797052 [details] [review]
[treeherder] KWierso:bug1306859 > mozilla:master

This should be a really quick review.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8797052 [details] [review]
[treeherder] KWierso:bug1306859 > mozilla:master

Short and sweet.  :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/861a9fc95978f08bd40cbd086c8877474e1ab17f
Bug 1306859 - Enable the bug filer for is_staff users (#1891) r=camd

This makes the button appear for anyone that is logged in and either in
the is_staff group or has '&bugfiler' in the URL.