Closed Bug 1306942 Opened 7 years ago Closed 7 years ago

Fix all-tabs-menu position in RTL locales

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 52
Iteration:
52.3 - Nov 14
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- verified

People

(Reporter: magicp.jp, Assigned: Towkir, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [devtools-html][lang=css])

Attachments

(3 files, 1 obsolete file)

fix-all-tabs-menu-position-in-rtl.png
11.09 KB, image/png
Details
all-tabs-menu-rtl.patch
1.03 KB, patch
ntim
: review+
Details | Diff | Splinter Review
verified-fixed-screenshot-2016-10-31.png
59.04 KB, image/png
Details 
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161001030430

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Inspector
3. Resize inspector sidebar until displaying all-tabs-menu


Actual results:

all-tabs-menu position is the start side.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=52cfd2babd94fa8452128940b50614cc12660785&tochange=45513d6773f099db66f0cd7bf1e312f6f9d11475


Expected results:

all-tabs-menu should place in the end side.
Blocks: 1305007
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Blocks: devtools-html-phase2
Whiteboard: [devtools-html] [triage]
Flags: qe-verify+
Priority: -- → P2
QA Contact: cristian.comorasu
Whiteboard: [devtools-html] [triage] → [devtools-html]
Mentor: ntim.bugs
Keywords: good-first-bug
Whiteboard: [devtools-html] → [devtools-html]lang=css]
To fix this bug:
- Remove the 4 lines here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#58
- Change right to offset-inline-end: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#45
- Simplify https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#48 to one simple border property: border-inline-start: 1px solid var(--theme-splitter-color)
Whiteboard: [devtools-html]lang=css] → [devtools-html][lang=css]
Towkir, are you interested in this bug ?
Flags: needinfo?(3ugzilla)
Thanks Tim,
I will submit a patch soon
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
Looking good on my local build.
Hope this helps :)
Attachment #8805488 - Flags: review?(ntim.bugs)
Iteration: --- → 52.3 - Nov 7
Priority: P2 → P1
Comment on attachment 8805488 [details] [diff] [review]
all-tabs-menu-rtl.patch

Review of attachment 8805488 [details] [diff] [review]:
-----------------------------------------------------------------

Works great, thanks!
Attachment #8805488 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e22d4c0e0f9d
Fix all-tabs-menu position in RTL locales. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e22d4c0e0f9d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Verified fixed in latest Nightly Build (20161030030204). Thanks!
status-firefox52: fixed → verified

        Attachment #8805877 -
        Attachment is obsolete: true
Flags: qe-verify+

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.