Fix all-tabs-menu position in RTL locales

VERIFIED FIXED in Firefox 52

Status

defect
P1
normal
VERIFIED FIXED
3 years ago
11 months ago

People

(Reporter: magicp.jp, Assigned: Towkir, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 52
Dependency tree / graph

Firefox Tracking Flags

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 verified)

Details

(Whiteboard: [devtools-html][lang=css])

Attachments

(3 attachments, 1 obsolete attachment)

Reporter

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161001030430

Steps to reproduce:

1. Start Nightly in RTL locales
2. Open DevTools > Inspector
3. Resize inspector sidebar until displaying all-tabs-menu


Actual results:

all-tabs-menu position is the start side.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=52cfd2babd94fa8452128940b50614cc12660785&tochange=45513d6773f099db66f0cd7bf1e312f6f9d11475


Expected results:

all-tabs-menu should place in the end side.
Reporter

Updated

3 years ago
Blocks: 1305007
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [devtools-html] [triage]
Flags: qe-verify+
Priority: -- → P2
QA Contact: cristian.comorasu
Whiteboard: [devtools-html] [triage] → [devtools-html]

Updated

3 years ago
Mentor: ntim.bugs
Keywords: good-first-bug
Whiteboard: [devtools-html] → [devtools-html]lang=css]

Comment 1

3 years ago
To fix this bug:
- Remove the 4 lines here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#58
- Change right to offset-inline-end: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#45
- Simplify https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css#48 to one simple border property: border-inline-start: 1px solid var(--theme-splitter-color)
Whiteboard: [devtools-html]lang=css] → [devtools-html][lang=css]

Comment 2

3 years ago
Towkir, are you interested in this bug ?
Flags: needinfo?(3ugzilla)
Assignee

Comment 3

3 years ago
Thanks Tim,
I will submit a patch soon
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Flags: needinfo?(3ugzilla)
Assignee

Comment 4

3 years ago
Looking good on my local build.
Hope this helps :)
Attachment #8805488 - Flags: review?(ntim.bugs)
Iteration: --- → 52.3 - Nov 7
Priority: P2 → P1

Comment 5

3 years ago
Comment on attachment 8805488 [details] [diff] [review]
all-tabs-menu-rtl.patch

Review of attachment 8805488 [details] [diff] [review]:
-----------------------------------------------------------------

Works great, thanks!
Attachment #8805488 - Flags: review?(ntim.bugs) → review+

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e22d4c0e0f9d
Fix all-tabs-menu position in RTL locales. r=ntim
Keywords: checkin-needed

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e22d4c0e0f9d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Reporter

Comment 8

3 years ago
Verified fixed in latest Nightly Build (20161030030204). Thanks!
Reporter

Updated

3 years ago
Reporter

Comment 9

3 years ago
Attachment #8805877 - Attachment is obsolete: true
Verified fixed based on Comment 8.
Status: RESOLVED → VERIFIED
Flags: qe-verify+

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.