1307022 - Move some code from MDSM::OnAudioDecoded/OnVideoDecoded/OnNotDecoded to state objects

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307022. Part 1 - Use raw pointers to avoid unnecessary ref-counting.

Review commit: https://reviewboard.mozilla.org/r/82962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82962/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307022. Part 2 - move some code from OnAudioDecoded() to various state objects.

Review commit: https://reviewboard.mozilla.org/r/82964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82964/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307022. Part 3 - Use raw pointers to avoid unnecessary ref-counting.

Review commit: https://reviewboard.mozilla.org/r/82966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82966/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307022. Part 4 - move some code from OnVideoDecoded() to various state objects.

Review commit: https://reviewboard.mozilla.org/r/82968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82968/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1307022. Part 5 - move some code from OnNotDecoded() to various state objects.

Review commit: https://reviewboard.mozilla.org/r/82970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82970/

Comment 6

[Tzuhao Kuo [:kaku]]

Comment on attachment 8797370 [details]
Bug 1307022. Part 1 - Use raw pointers to avoid unnecessary ref-counting.

https://reviewboard.mozilla.org/r/82962/#review81694

Comment 7

[Tzuhao Kuo [:kaku]]

Comment on attachment 8797371 [details]
Bug 1307022. Part 2 - move some code from OnAudioDecoded() to various state objects.

https://reviewboard.mozilla.org/r/82964/#review81696

Comment 8

[Tzuhao Kuo [:kaku]]

Comment on attachment 8797372 [details]
Bug 1307022. Part 3 - Use raw pointers to avoid unnecessary ref-counting.

https://reviewboard.mozilla.org/r/82966/#review81698

Comment 9

[Tzuhao Kuo [:kaku]]

Comment on attachment 8797373 [details]
Bug 1307022. Part 4 - move some code from OnVideoDecoded() to various state objects.

https://reviewboard.mozilla.org/r/82968/#review81700

Comment 10

[Tzuhao Kuo [:kaku]]

Comment on attachment 8797374 [details]
Bug 1307022. Part 5 - move some code from OnNotDecoded() to various state objects.

https://reviewboard.mozilla.org/r/82970/#review81702

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a1edf61eb2b
Part 1 - Use raw pointers to avoid unnecessary ref-counting. r=kaku
https://hg.mozilla.org/integration/autoland/rev/8b54936366ea
Part 2 - move some code from OnAudioDecoded() to various state objects. r=kaku
https://hg.mozilla.org/integration/autoland/rev/4e654ea0dfa6
Part 3 - Use raw pointers to avoid unnecessary ref-counting. r=kaku
https://hg.mozilla.org/integration/autoland/rev/e145b5d95343
Part 4 - move some code from OnVideoDecoded() to various state objects. r=kaku
https://hg.mozilla.org/integration/autoland/rev/1ebe25b02ffe
Part 5 - move some code from OnNotDecoded() to various state objects. r=kaku

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a1edf61eb2b
https://hg.mozilla.org/mozilla-central/rev/8b54936366ea
https://hg.mozilla.org/mozilla-central/rev/4e654ea0dfa6
https://hg.mozilla.org/mozilla-central/rev/e145b5d95343
https://hg.mozilla.org/mozilla-central/rev/1ebe25b02ffe