The tip of caret is covered by input area

VERIFIED FIXED in Firefox 51

Status

()

Firefox for Android
Text Selection
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks: 1 bug, {regression})

unspecified
Firefox 52
regression
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox50 unaffected, firefox51 verified, firefox52 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

Created attachment 8797028 [details]
Screenshot_20161003-113501.png

Tap on a input area like Google search, and the tip of the single caret is covered by the input area. I don't recall this happens. A regression probably.
I guess this regression came from bug 1292904 since it modified the css of carets.
Depends on: 1292904
Assignee: nobody → tlin
status-firefox50: --- → unaffected
status-firefox51: --- → affected
status-firefox52: --- → affected
Comment hidden (mozreview-request)
Created attachment 8797102 [details]
after-fix-selection.png
Regressing bugs should be in the blocks field (always confusing, I know).
Blocks: 1292904
No longer depends on: 1292904

Comment 6

2 years ago
mozreview-review
Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

https://reviewboard.mozilla.org/r/82710/#review81704
Attachment #8797058 - Flags: review?(mtseng) → review+

Comment 7

2 years ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b27a34720a75
Fix vertical position for caret images. r=mtseng

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b27a34720a75
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

Approval Request Comment
[Feature/regressing bug #]: Fix regression caused by bug 1292904.
[User impact if declined]: UI defect. The tip of the caret is cut off.
[Describe test coverage new/current, TreeHerder]: Merged on master. 
[Risks and why]: Low risk. No functional changes, just css tweaks.
[String/UUID change made/needed]: None.
Attachment #8797058 - Flags: approval-mozilla-aurora?
Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

Fix a regression related to the tip of caret. Take it in 51 aurora.
Attachment #8797058 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

2 years ago
Flags: qe-verify+

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/d1db21ca0e4e
status-firefox51: affected → fixed
Verified as fixed in build:
- Aurora 51.0a2 (2016-10-07);
- Nightly 52.0a1 (2016-10-07);
Device: Asus ZenPad 8 (Android 5.0.2) and Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
status-firefox51: fixed → verified
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.