1307027 - The tip of caret is covered by input area

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Screenshot_20161003-113501.png

Tap on a input area like Google search, and the tip of the single caret is covered by the input area. I don't recall this happens. A regression probably.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I guess this regression came from bug 1292904 since it modified the css of carets.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1307027 - Fix vertical position for caret images.

After the splitting of text overlay and the caret images, the caret image should
be placed from the top of #image div.

Delete those "top" style for Fennec since they're not needed anymore in current
setup.

Review commit: https://reviewboard.mozilla.org/r/82710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82710/

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: after-fix-cursor.png

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: after-fix-selection.png

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Regressing bugs should be in the blocks field (always confusing, I know).

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

https://reviewboard.mozilla.org/r/82710/#review81704

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b27a34720a75
Fix vertical position for caret images. r=mtseng

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b27a34720a75

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

Approval Request Comment
[Feature/regressing bug #]: Fix regression caused by bug 1292904.
[User impact if declined]: UI defect. The tip of the caret is cut off.
[Describe test coverage new/current, TreeHerder]: Merged on master. 
[Risks and why]: Low risk. No functional changes, just css tweaks.
[String/UUID change made/needed]: None.

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8797058 [details]
Bug 1307027 - Fix vertical position for caret images.

Fix a regression related to the tip of caret. Take it in 51 aurora.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d1db21ca0e4e

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build:
- Aurora 51.0a2 (2016-10-07);
- Nightly 52.0a1 (2016-10-07);
Device: Asus ZenPad 8 (Android 5.0.2) and Nexus 5 (Android 6.0.1).

Comment 13

[Stefan Deiac]

I will remove the qe-verify flag based on comment 12, thanks.