Closed Bug 1307132 Opened 5 years ago Closed 5 years ago
.js relies on App Constants but is used from cookies .xul which does not import it at any point
[Tracking Requested - why for this release]: regression introduced in v51
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8797193 [details] Bug 1307132 - import AppConstants.jsm, https://reviewboard.mozilla.org/r/82792/#review82520
Attachment #8797193 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3ee1fa4da71b import AppConstants.jsm, r=jaws
Hi :Gijs, Since this bug is a regression and also affects 51, do you consider to uplift this for 51?
Comment on attachment 8797193 [details] Bug 1307132 - import AppConstants.jsm, Approval Request Comment [Feature/regressing bug #]: bug 1294989 [User impact if declined]: parts of the preferences' cookies dialog don't work correctly. [Describe test coverage new/current, TreeHerder]: noooope, or we would have noticed earlier. I think the cookies dialog itself does have tests, just not once that noticed this breakage. [Risks and why]: very low, effectively a 1-liner. [String/UUID change made/needed]: nope
Attachment #8797193 - Flags: approval-mozilla-aurora?
Comment on attachment 8797193 [details] Bug 1307132 - import AppConstants.jsm, Fix a regression. Take it in 51 aurora.
Attachment #8797193 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.