1307132 - cookies.js relies on AppConstants but is used from cookies.xul which does not import it at any point

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:Gijs (he/him)]

Noticed on my nightly build that if you open the cookies dialog and hit a key, you get:

JavaScript error: chrome://browser/content/preferences/cookies.js, line 762: ReferenceError: AppConstants is not defined

This looks like a regression from bug 1294989

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: regression introduced in v51

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1307132 - import AppConstants.jsm,

Review commit: https://reviewboard.mozilla.org/r/82792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82792/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,

https://reviewboard.mozilla.org/r/82792/#review82520

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ee1fa4da71b
import AppConstants.jsm, r=jaws

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3ee1fa4da71b

Comment 6

[Gerry Chang [:gchang]]

Track 51+ as regression.

Comment 7

[Gerry Chang [:gchang]]

Hi :Gijs,
Since this bug is a regression and also affects 51, do you consider to uplift this for 51?

Comment 8

[:Gijs (he/him)]

Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,

Approval Request Comment
[Feature/regressing bug #]: bug 1294989
[User impact if declined]: parts of the preferences' cookies dialog don't work correctly.
[Describe test coverage new/current, TreeHerder]: noooope, or we would have noticed earlier. I think the cookies dialog itself does have tests, just not once that noticed this breakage.
[Risks and why]: very low, effectively a 1-liner.
[String/UUID change made/needed]: nope

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,

Fix a regression. Take it in 51 aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca710272133c