Enable ECMAScript's Intl API on larch

RESOLVED FIXED

Status

L20n
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stas, Unassigned)

Tracking

Details

(Whiteboard: [gecko-l20n])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This is a mirror bug to bug 1215247.

For our work in bug 1303883 we need to have the Intl API enabled in Android builds of larch.
(Reporter)

Updated

2 years ago
Blocks: 1303883
(Reporter)

Comment 1

2 years ago
Landed in http://hg.mozilla.org/projects/larch/rev/836e720e70ce.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

2 years ago
Looks like this broke our XPCShell integration tests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be582da09d8

I'm looking into it.
(Reporter)

Comment 3

2 years ago
Zibi, any idea why the XPCShell tests for mozintl would fail with this patch?
Flags: needinfo?(gandalf)
(Reporter)

Comment 4

2 years ago
Hey :m_kato, for our work on L20n in Desktop and Android I landed your patch from bug 1215247 on larch.  I ran into a XPCShell test failure:

TEST-UNEXPECTED-FAIL | intl/locale/tests/unit/test_intl_on_workers.js | xpcshell return code: 0
SyntaxError: Failed to load worker script at "chrome://locale/content/intl_on_workers_worker.js

I was able to reproduce this locally and I also verified that the worker file is correctly being registered in the chrome registry under the above URI.  Do you know what might be the cause of the failure?  I'm not quite sure where that SyntaxError is coming from.
Flags: needinfo?(m_kato)
(In reply to Staś Małolepszy :stas from comment #4)
> Hey :m_kato, for our work on L20n in Desktop and Android I landed your patch
> from bug 1215247 on larch.  I ran into a XPCShell test failure:
> 
> TEST-UNEXPECTED-FAIL | intl/locale/tests/unit/test_intl_on_workers.js |
> xpcshell return code: 0
> SyntaxError: Failed to load worker script at
> "chrome://locale/content/intl_on_workers_worker.js
> 
> I was able to reproduce this locally and I also verified that the worker
> file is correctly being registered in the chrome registry under the above
> URI.  Do you know what might be the cause of the failure?  I'm not quite
> sure where that SyntaxError is coming from.

Even if I comment out Intl usage on this script, this test causes SyntaxError.  When using default (--with-intl-api=no), it will causes same error even if changing to "let myLocale = null;".  So I think that this doesn't depends on Intl API.
Flags: needinfo?(m_kato)
Also, we turn off all worker tests into dom/workers/test/xpcshell/* on Android's xpcshell.
(Reporter)

Comment 8

2 years ago
(In reply to Makoto Kato [:m_kato] from comment #6)

> Even if I comment out Intl usage on this script, this test causes
> SyntaxError.  When using default (--with-intl-api=no), it will causes same
> error even if changing to "let myLocale = null;".  So I think that this
> doesn't depends on Intl API.

Thanks for looking into this!  I also tried something as simple as `var a = 1;` and still got the SyntaxError, but wasn't sure if I was testing the right thing.
Comment hidden (mozreview-request)
(Reporter)

Updated

2 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 10

2 years ago
mozreview-review
Comment on attachment 8798868 [details]
Bug 1307164 - Enable Intl API on Android; fix mozIntl tests.

https://reviewboard.mozilla.org/r/84238/#review82868
Attachment #8798868 - Flags: review?(gandalf) → review+
(Reporter)

Comment 11

2 years ago
https://hg.mozilla.org/projects/larch/rev/d151ab07062e783e89e401655dbd6727cf29a01f
Bug 1307164 - Enable Intl API on Android; fix mozIntl tests. r=gandalf
(Reporter)

Comment 12

2 years ago
Closing this as fixed.  The one failing test isn't probably related to this and should be taken care of as a separate issue.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Flags: needinfo?(gandalf)
Resolution: --- → FIXED

Updated

2 years ago
Depends on: 1309447

Comment 13

2 years ago
We managed to get this landed on larch without bug 1309447.
No longer depends on: 1309447
You need to log in before you can comment on or make changes to this bug.