1307199 - Favicon of a redirecting bookmark not set when history is disabled

Status: NEW

(Toolkit :: Places, defect, P3)

Description

[mandarke]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160920074044

Steps to reproduce:

right-click on bookmark toolbar to manually add http://arstechnica.co.uk/?view=archive


Actual results:

the bookmark was created with the default grey globe icon appearing.


Expected results:

after clicking on the newly created bookmark i was expecting the grey globe icon to change to the site's favicon shown on the browser tab. this did not happen.

Comment 1

[Marco Bonardo [:mak]]

I cannot reproduce with the provided steps, the bookmark takes the icon on first load.
Did you try in safe mode?
https://support.mozilla.org/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 2

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #1)
> I cannot reproduce with the provided steps, the bookmark takes the icon on
> first load.
> Did you try in safe mode?
> https://support.mozilla.org/kb/troubleshoot-firefox-issues-using-safe-mode

do you have "remember my browsing and download history" unticked?

it happens every time i try to add or edit an address that redirects. looking at the exported bookmark shows no favicon location.

Comment 3

[Marco Bonardo [:mak]]

(In reply to mandarke from comment #2)
> do you have "remember my browsing and download history" unticked?

Nope, comment 0 didn't point that out as a requirement.

> it happens every time i try to add or edit an address that redirects.
> looking at the exported bookmark shows no favicon location.

So, favicons in general are considered part of history, but for bookmarks we should be allowing bypassing a disabled history. But it's possible the bypass is bogus in case of redirects. This is what should be verified.