1307226 - clang 3.8 crashes when compiling changes from bug 1151204

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

On Fedora with clang-3.8, clang crashes when compiling with the changes from bb3080bc1aad from bug 1151204. The issue seems to be similar to one that's already worked around in that code (see https://hg.mozilla.org/mozilla-central/rev/bb3080bc1aad#l1.28 and https://hg.mozilla.org/mozilla-central/rev/bb3080bc1aad#l1.183 ). If I extend the CLANG_CRASH_BUG macro to cover 3.8 and wrap the assertion at https://hg.mozilla.org/mozilla-central/rev/bb3080bc1aad#l1.146 with the same #ifndef CLANG_CRASH_BUG, compilation succeeds.

Comment 1

[Mats Palmgren (inactive)]

That's odd, I'm using 3.8 myself and it compiles fine for me:
clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
Target: x86_64-pc-linux-gnu

What's the output from your "clang --version" ?

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Interesting - I was wondering why it seemed others hadn't encountered this and filed a bug before me...
In any case:

clang version 3.8.0 (tags/RELEASE_380/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Comment 3

[Mats Palmgren (inactive)]

Weird, maybe the clang bug is still present then, but depends on some
other unknown factor which are no longer present on my system.

It sounds like you wrote a patch already, can you attach it
and ask for review please?

BTW, I see that we use g++ on mozilla-inbound so the assertions
should still be active there.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount

Review commit: https://reviewboard.mozilla.org/r/82884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82884/

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Ok - there's the patch. I'll keep investigating, though - I'm still confused as to why it seems only I have encountered this issue.

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8797283 [details]
bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount

https://reviewboard.mozilla.org/r/82884/#review81524

Thanks! r=mats with this nit:

Could we make the last factor there "__clang_minor__ <= 8" instead?
I see no reason why 3.7 isn't affected in the light of 3.8 crashing (for some).
That will of course disable the assertions on all 3.x up to and including 3.8,
but I think that's fine.

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8797283 [details]
bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/82884/diff/1-2/

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a4288cc3cea
extend clang crash workaround to work around similar crash in SetGridItemCount r=mats

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1a4288cc3cea