Closed
Bug 1307235
Opened 8 years ago
Closed 8 years ago
"ReferenceError: Utils is not defined" in SessionStore.jsm
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jchen, Assigned: ckerschb)
References
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
There are a lot of "ReferenceError: Utils is not defined" messages in adb logcat, coming from SessionStore.jsm (e.g. [1]). I think bug 1297338 forgot to import "resource:///modules/sessionstore/Utils.jsm". [1] https://dxr.mozilla.org/mozilla-central/rev/955840bfd3c20eb24dd5a01be27bdc55c489a285/mobile/android/components/SessionStore.js#1215
Flags: needinfo?(ckerschb)
|
Assignee | |
Comment 1•8 years ago
|
||
You are right, thanks for filing the bug!
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Flags: needinfo?(ckerschb)
Attachment #8797411 -
Flags: review?(nchen)
|
Reporter | |
Updated•8 years ago
|
Attachment #8797411 -
Flags: review?(nchen) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf23f8fe42fb Import sessionstore/Utils into android/components/SessionStore. r=jchen
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cf23f8fe42fb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 4•8 years ago
|
||
Did this patch help? I still see lots of "Utils is not defined" in test logcats. How can we find where this is coming from? http://mozilla-releng-blobs.s3.amazonaws.com/blobs/mozilla-inbound/sha512/5c60170691c950f2daf3f9b2e8ecddcba5532f8d756d5eaabaedb7293d6903bbd3a3b0fca17f24a3710cfe0581d697fd0b8977a6c65111175e511ef9236607db
Flags: needinfo?(nchen)
Flags: needinfo?(ckerschb)
|
|
||
Comment 5•8 years ago
|
||
Let's sort this out in bug 1313397.
Flags: needinfo?(nchen)
Flags: needinfo?(ckerschb)
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•