1307248 - Use Is{Widevine,Primetime}KeySystem(string) instead of !CompareUTF8toUTF16(kEMEKeySystem*, string)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Whenever I use !CompareUTF8toUTF16(kEMEKeySystem*, string) to detect a keysystem string, I forget to include the '!' on the Compare*() call.

We should use have appropriately named helpers, so that it's easier to use.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1307248 - Add Is{Primetime,Widevine}KeySystem() functions.

Review commit: https://reviewboard.mozilla.org/r/82876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82876/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1307248 - Replace uses of CompareUTF8toUTF16(kEMEKeySystem*) with Is*KeySystem().

Review commit: https://reviewboard.mozilla.org/r/82878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82878/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8797277 [details]
Bug 1307248 - Add Is{Primetime,Widevine}KeySystem() functions.

https://reviewboard.mozilla.org/r/82876/#review81594

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8797278 [details]
Bug 1307248 - Replace uses of CompareUTF8toUTF16(kEMEKeySystem*) with Is*KeySystem().

https://reviewboard.mozilla.org/r/82878/#review81596

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1de4e6e383b9
Add Is{Primetime,Widevine}KeySystem() functions. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/49a429cb34a6
Replace uses of CompareUTF8toUTF16(kEMEKeySystem*) with Is*KeySystem(). r=jwwang

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1de4e6e383b9
https://hg.mozilla.org/mozilla-central/rev/49a429cb34a6