Closed Bug 1307250 Opened 5 years ago Closed 5 years ago

Add dir attribute to index.html

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: wldcordeiro, Assigned: wldcordeiro)

Details

Attachments

(2 files)

Recently ntim brought up the fact that we were lacking this attribute on our index.html file and explained that it would be used for us to change the direction of the debugger for rtl users. This is a patch for upstream m-c.

ping, jlongster
Assignee: nobody → wellington
Attachment #8797284 - Flags: review+
Harmless change, no tests needed. Thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e939b4e29de3
Add dir attribute to index.html. r=jlongster
Keywords: checkin-needed
Attached image new-debugger-rtl.png
The reason modules have to specify dir="" on the document element is so that we avoid setting RTL if the support is not optimal.

Here is a screenshot of the new debugger in Nightly with RTL enabled. There are a few issues here:
- code is displayed in RTL (should keep LTR)
- source tree is not properly indented
- arrows are in the wrong direction
- icons are overlapping

Unless you are planning to fully support RTL, I would advise against this change for now.
Flags: needinfo?(wellington)
https://hg.mozilla.org/mozilla-central/rev/e939b4e29de3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Julian,

We've added an issue to the github tracker with with your list of problems. We'll be trying to address these things for the next m-c merge and prior to the nightly->aurora move, if that doesn't happen, myself or someone will make another patch removing the `dir=""` until we are ready.
Flags: needinfo?(wellington)
Sounds good, thanks for the follow up! A working LTR is always better than a broken RTL :)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.