1307250 - Add dir attribute to index.html

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Wellington Cordeiro [:wldcordeiro]]

Attachment: debugger-index-dir.patch

Recently ntim brought up the fact that we were lacking this attribute on our index.html file and explained that it would be used for us to change the direction of the debugger for rtl users. This is a patch for upstream m-c.

ping, jlongster

Comment 1

[James Long (:jlongster)]

Harmless change, no tests needed. Thanks!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e939b4e29de3
Add dir attribute to index.html. r=jlongster

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: new-debugger-rtl.png

The reason modules have to specify dir="" on the document element is so that we avoid setting RTL if the support is not optimal.

Here is a screenshot of the new debugger in Nightly with RTL enabled. There are a few issues here:
- code is displayed in RTL (should keep LTR)
- source tree is not properly indented
- arrows are in the wrong direction
- icons are overlapping

Unless you are planning to fully support RTL, I would advise against this change for now.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e939b4e29de3

Comment 5

[Wellington Cordeiro [:wldcordeiro]]

Julian,

We've added an issue to the github tracker with with your list of problems. We'll be trying to address these things for the next m-c merge and prior to the nightly->aurora move, if that doesn't happen, myself or someone will make another patch removing the `dir=""` until we are ready.

Comment 6

[Julian Descottes [:jdescottes]]

Sounds good, thanks for the follow up! A working LTR is always better than a broken RTL :)