1307328 - Find in page highlight doesn't match searched words

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Brian Birtles (:birtles)]

STR:

1. Load https://public.etherpad-mozilla.org/p/mozanime
2. Press Ctrl+F
3. Type "move" (without the quotes)
4. Press F3

Expected results:
Instances of the word "move" are highlighted.

Actual results:
After step 3 the word "move" is highlighted. After pressing F3, however, the document is scroll but the highlight area remains the same such that the contents of the highlight does not include the word "move" (or any word really). Furthermore, after scrolling the page, the highlight area remains fixed (i.e. doesn't follow the scroll).

Noticed this on Win 10 but hiro reproduced on Linux.

Comment 1

[Brian Birtles (:birtles)]

Attachment: Screenshot (after step 4)

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1307328 - nested iframes combined with scrolling=no require special attention for rect positioning inside the findbar dimmed background.

Review commit: https://reviewboard.mozilla.org/r/83632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83632/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8798023 [details]
Bug 1307328 - nested iframes combined with scrolling=no require special attention for rect positioning inside the findbar dimmed background.

https://reviewboard.mozilla.org/r/83632/#review83196

::: toolkit/modules/FinderHighlighter.jsm:612
(Diff revision 1)
> +        // is also an iframe the scroll offsets from the parents' documentElement
> +        // (inverse scroll position) needs to be subtracted from the parent
> +        // window rect.
> +        if (el.getAttribute("scrolling") == "no" && currWin != window.top) {
> +          let docEl = currWin.document.documentElement;
> +          parentRect.translate(-docEl.scrollLeft, -docEl.scrollTop);

Do we need to do anything special here for RTL?

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Jared Wein [:jaws] (overloaded with reviews / please needinfo? me) from comment #3)
> Do we need to do anything special here for RTL?

No, `scrollLeft` is locale-aware: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollLeft

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58e07e9d572a
nested iframes combined with scrolling=no require special attention for rect positioning inside the findbar dimmed background. r=jaws

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58e07e9d572a

Comment 8

[roxleitan]

Verified fixed using the latest Nightly 52.0a1 (Build ID: 20161109030210) on Ubuntu 16.04 and Windows 10 x64.
I can still see an issue with the white highlight. When navigates through matches the highlight is moved with delay. For this I filed bug 1312008.

Considering the above, setting the status verified fixed.