1307344 - [pontoon] Few Imported strings has double spaces

Status: RESOLVED FIXED

(Mozilla Localizations :: te / Telugu, defect, P3)

Description

[Dinesh Mv]

I was working on #1306679 for which i was checking each sub file in Firefox Aurora and found that some imported strings have double spaces.
Ex: https://pontoon.mozilla.org/te/firefox-aurora/toolkit/chrome/mozapps/preferences/removemp.dtd   This was resolved by me recently. 

Expected output:
Pontoon must throw an error while importing odd strings with double spaces to enhance better quality
Actual input: 
Strings with double spaces have been accepted on pontoon.

Comment 1

[Dinesh Mv]

There many constraints for to consider in this case. 
Is there anyway to find strings with double spaces on pontoon or transvision? 
So that we can find the affected strings during migration and correct them manually.

Any alternatives ?

Comment 2

[Francesco Lodolo [:flod]]

Attachment: results.txt

In .dtd files double spaces should be collapsed to one, like in HTML pages. There's no way to find those in Transvision, since we trim whitespaces.

Not sure how reliable the script I've used is, but there seem to be over 800 strings with double spaces.

Comment 3

[Dinesh Mv]

Hi flod, 
Thanks for the details you mentioned. This will be helpful to manually edit them.

Is there anyway for contributors to find such strings without transvision?

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Dinesh Mv from comment #3)
> Is there anyway for contributors to find such strings without transvision?
Not that I know, besides cloning the repository and searching with regular expressions.

Comment 5

[Dinesh Mv]

Ok! 
So, the only solution for this is manually editing each of the strings right?

Comment 6

[Francesco Lodolo [:flod]]

It might be possible to create a script to remove most of them, but it would still be quite risky, and will need manual checks afterwards.

Comment 7

[Dinesh Mv]

There are white spaces for few strings which will be similar like double spaces. Writing a script to remove double spaces might effect that ? won't it?

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Dinesh Mv from comment #7)
> There are white spaces for few strings which will be similar like double
> spaces. Writing a script to remove double spaces might effect that ? won't
> it?

That's why I said it would be risky.

Comment 9

[Dinesh Mv]

Yes. We will try to engage our contributors to work manually on these strings.

Comment 10

[Dinesh Mv]

Assigning this bug to our contributor.

Comment 11

[haripriyagundala]

Thank you, Dinesh. 
I will work on this issue. I will let you know after solving this issue.

Comment 12

[Dinesh Mv]

@haripriya, You can use the attachment from Comment #3 to find those strings.

Comment 13

[Dinesh Mv]

Sorry, You can use the attachment from Comment #2 to find those strings.

Comment 14

[haripriyagundala]

Thanks Dinesh.

(In reply to Francesco Lodolo [:flod] from comment #2)
> Created attachment 8797367 [details]
> results.txt

@Flod- we made many changes. I just want to clarify with left over strings. Can you please update with new results attachment?

Comment 15

[Francesco Lodolo [:flod]]

Attachment: results.txt

Updated list, I removed the one actually spanning multiple lines (like HTML pieces).

Comment 16

[Dinesh Mv]

@flod- Please recheck now and Is there any chance to count the number of available white-space strings in english so that it will be easy to predict the efficiency here. 

Let me know the number/list of double-spaced/white-spaced strings that exists in 'te' now

Comment 17

[Francesco Lodolo [:flod]]

Attachment: results.txt

I think you're pretty much done: I count about 250 strings for English, and 290 for Telugu. If you want to go through the list and check something more, that's great, but you shouldn't probably spend more time on it.

I can help clean up the aboutTelemetry.dtd file tomorrow directly from Mercurial.

Comment 18

[Francesco Lodolo [:flod]]

Actually, already did since it's a fast process
https://hg.mozilla.org/releases/l10n/mozilla-aurora/te/rev/ffbe460f92065eee4846f1f2605225da7811fade

Pontoon should read them in a few minutes.

Comment 19

[Dinesh Mv]

(In reply to Francesco Lodolo [:flod] from comment #17)
> I can help clean up the aboutTelemetry.dtd file tomorrow directly from Mercurial.

But, the source strings in telemetry.dtd has white spaces for many words in the source lang.[en-us]. would it be wise to remove white spaces in the destination[te] file? 

I think this is the only file which is left. After this being resolved, I will resolve this bug

Comment 20

[Francesco Lodolo [:flod]]

(no need to use the needinfo)

That's up to you, I personally prefer to not have double spaces. Having said that, I think this bug can be safely closed.

Comment 21

[Dinesh Mv]

Alright! I will leave it as it is now (without spaces) 
This issue is mostly solved now.
Thanks for the support @flod and @haripriya