All users were logged out of Bugzilla on October 13th, 2018

Disable async stacks by default in the JS shell

ASSIGNED
Assigned to
(NeedInfo from)

Status

()

P3
normal
ASSIGNED
2 years ago
a year ago

People

(Reporter: till, Assigned: till, NeedInfo)

Tracking

({triage-deferred})

Trunk
triage-deferred
Points:
---

Firefox Tracking Flags

(firefox52 wontfix)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Async stack capturing causes significant overlay in heavily Promise-using code. To make perf testing simpler in the shell, disable them by default and add an option for enabling them. Patch coming up.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8797612 [details]
Bug 1307446 - Disable async stacks by default in the JS shell and add command line option for enabling them.

https://reviewboard.mozilla.org/r/83280/#review81770
Attachment #8797612 - Flags: review?(evilpies) → review+

Comment 3

2 years ago
Pushed by tschneidereit@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/122e1eaf7a4c
Disable async stacks by default in the JS shell and add command line option for enabling them. r=evilpie
Backed out for failing saved-stacks/async-principals.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/50ba9c7b5e260a0e25beb63687ca5ef6acae8833

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=122e1eaf7a4ce92249a85a6fde8df8c64859c19e
Failure log: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=122e1eaf7a4ce92249a85a6fde8df8c64859c19e

[task 2016-10-04T15:37:03.791692Z] TEST-PASS | js/src/jit-test/tests/saved-stacks/asm-frames.js | Success (code 0, args "--no-baseline --no-ion")
[task 2016-10-04T15:37:03.819119Z] TEST-PASS | js/src/jit-test/tests/saved-stacks/asm-frames.js | Success (code 0, args "")
[task 2016-10-04T15:37:03.839864Z] /home/worker/workspace/sm-package/mozjs-52.0a1.0/js/src/jit-test/tests/saved-stacks/async.js:14:3 Error: Assertion failed: got ({}), expected null
[task 2016-10-04T15:37:03.839925Z] Stack:
[task 2016-10-04T15:37:03.839969Z]   asyncCallback@/home/worker/workspace/sm-package/mozjs-52.0a1.0/js/src/jit-test/tests/saved-stacks/async.js:14:3
[task 2016-10-04T15:37:03.840018Z]   @/home/worker/workspace/sm-package/mozjs-52.0a1.0/js/src/jit-test/tests/saved-stacks/async.js:10:1
[task 2016-10-04T15:37:03.840042Z] Exit code: 3
[task 2016-10-04T15:37:03.840064Z] FAIL - saved-stacks/async.js
Flags: needinfo?(till)
Too late for firefox 52, mass-wontfix.
status-firefox52: affected → wontfix
Keywords: triage-deferred
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.