1307456 - Remove WebPackagedApp code

Status: RESOLVED FIXED

(Core :: Networking, defect)

Comment 1

[[:fabrice] Fabrice Desré]

iirc, this was not just for packaged apps, but also intended as a bundling mechanism for web resources (like "everything you need for this slide deck"). At least I'm pretty sure that was a motivation for Jonas.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

That is true, however, a lot of the code was specifically dependent on assumptions that were made for b2g - especially the signature verifying bits.
And while I think this is a pretty interesting format/feature, I don't see any traction for it to become a web standard anytime soon. The package format and addressing scheme are still a very good idea.
We can add the code back in at a later point if there's someone willing to use it.

Comment 3

[(no longer active)]

Valentin, can you please also remove dom/newapps when you get to this?  It seems like that directory is only used by PackagedAppDownloader::InstallSignedPackagedApp().  Thank you!

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307456 - Remove dom/newapps

Review commit: https://reviewboard.mozilla.org/r/87320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87320/

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307456 - Remove PackagedAppService/Verifier

Review commit: https://reviewboard.mozilla.org/r/87322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87322/

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1307456 - Remove packaged app related changes to nsMultiMixedConv

Review commit: https://reviewboard.mozilla.org/r/87324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87324/

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803106 [details]
Bug 1307456 - Remove dom/newapps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87320/diff/1-2/

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803107 [details]
Bug 1307456 - Remove PackagedAppService/Verifier

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87322/diff/1-2/

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803108 [details]
Bug 1307456 - Remove packaged app related changes to nsMultiMixedConv

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87324/diff/1-2/

Comment 10

[Daniel Stenberg [:bagder]]

Comment on attachment 8803107 [details]
Bug 1307456 - Remove PackagedAppService/Verifier

https://reviewboard.mozilla.org/r/87322/#review86918

Comment 11

[Daniel Stenberg [:bagder]]

Comment on attachment 8803108 [details]
Bug 1307456 - Remove packaged app related changes to nsMultiMixedConv

https://reviewboard.mozilla.org/r/87324/#review86920

Less is more! Just a little question but still r+

::: netwerk/streamconv/converters/nsMultiMixedConv.cpp:760
(Diff revision 2)
>  NS_IMETHODIMP
>  nsMultiMixedConv::OnStopRequest(nsIRequest *request, nsISupports *ctxt,
> -                                nsresult aStatus) {
> -
> -    nsresult rv = NS_OK;
> -
> +                                nsresult aStatus)
> +{
> +    if (mToken.IsEmpty()) { // no token, no love.
> +        return NS_ERROR_FAILURE;

This seems simpler and slightly more widely covering than the code did before, even in the non-packagedapp case. Just wanted to make sure this is intended.

Comment 12

[Andrea Marchesini [:baku]]

Comment on attachment 8803106 [details]
Bug 1307456 - Remove dom/newapps

https://reviewboard.mozilla.org/r/87320/#review88532

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803108 [details]
Bug 1307456 - Remove packaged app related changes to nsMultiMixedConv

https://reviewboard.mozilla.org/r/87324/#review86920

> This seems simpler and slightly more widely covering than the code did before, even in the non-packagedapp case. Just wanted to make sure this is intended.

This is how the code used to look like before we made it more complex with the packaged app use cases.

Comment 14

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803106 [details]
Bug 1307456 - Remove dom/newapps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87320/diff/2-3/

Comment 15

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803107 [details]
Bug 1307456 - Remove PackagedAppService/Verifier

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87322/diff/2-3/

Comment 16

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8803108 [details]
Bug 1307456 - Remove packaged app related changes to nsMultiMixedConv

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87324/diff/2-3/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75890b9806e8
Remove dom/newapps r=baku
https://hg.mozilla.org/integration/autoland/rev/e51be7bba9f5
Remove PackagedAppService/Verifier r=bagder
https://hg.mozilla.org/integration/autoland/rev/0f50ce32748d
Remove packaged app related changes to nsMultiMixedConv r=bagder

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/75890b9806e8
https://hg.mozilla.org/mozilla-central/rev/e51be7bba9f5
https://hg.mozilla.org/mozilla-central/rev/0f50ce32748d

Comment 19

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=977036f8cbd9