1307469 - Crash in OOM | large | NS_ABORT_OOM | nsTArray_base<T>::EnsureCapacity<T> | nsTArray_Impl<T>::AppendElement<T> | `anonymous namespace''::internal_Accumulate

Status: RESOLVED DUPLICATE of bug 1304519

(Core :: DOM: Workers, defect)

Description

[alex_mayorga]

This bug was filed from the Socorro interface and is 
report bp-f1db6841-0b51-4c1f-8c50-818d22161004.
=============================================================

¡Hola!

Recently crashed like this.

Guessing a component from the stack.

27 other Nightly crashes in the past week at https://crash-stats.mozilla.com/signature/?product=Firefox&signature=OOM%20%7C%20large%20%7C%20NS_ABORT_OOM%20%7C%20nsTArray_base%3CT%3E%3A%3AEnsureCapacity%3CT%3E%20%7C%20nsTArray_Impl%3CT%3E%3A%3AAppendElement%3CT%3E%20%7C%20%60anonymous%20namespace%27%27%3A%3Ainternal_Accumulate

¡Gracias!
Alex

Crashing Thread (32)
Frame 	Module 	Signature 	Source
0 	xul.dll 	NS_ABORT_OOM(unsigned __int64) 	xpcom/base/nsDebugImpl.cpp:606
1 	xul.dll 	nsTArray_base<nsTArrayInfallibleAllocator, nsTArray_CopyWithMemutils>::EnsureCapacity<nsTArrayInfallibleAllocator>(unsigned __int64, unsigned __int64) 	obj-firefox/dist/include/nsTArray-inl.h:128
2 	xul.dll 	nsTArray_Impl<mozilla::dom::Element*, nsTArrayInfallibleAllocator>::AppendElement<mozilla::dom::Element*&, nsTArrayInfallibleAllocator>(mozilla::dom::Element*&) 	obj-firefox/dist/include/nsTArray.h:2073
3 	xul.dll 	`anonymous namespace'::internal_Accumulate 	toolkit/components/telemetry/TelemetryHistogram.cpp:1381
4 	xul.dll 	nsCycleCollector::CleanupAfterCollection() 	xpcom/base/nsCycleCollector.cpp:3568
5 	xul.dll 	nsCycleCollector::Collect(ccType, js::SliceBudget&, nsICycleCollectorListener*, bool) 	xpcom/base/nsCycleCollector.cpp:3678
6 	xul.dll 	nsCycleCollector_collect(nsICycleCollectorListener*) 	xpcom/base/nsCycleCollector.cpp:4144
7 	xul.dll 	`anonymous namespace'::WorkerJSContext::CustomGCCallback 	dom/workers/RuntimeService.cpp:1131
8 	xul.dll 	js::gc::GCRuntime::callGCCallback(JSGCStatus) 	js/src/jsgc.cpp:1356
9 	xul.dll 	`anonymous namespace'::AutoNotifyGCActivity::~AutoNotifyGCActivity 	js/src/jsgc.cpp:1387
10 	xul.dll 	js::gc::GCRuntime::gcCycle(bool, js::SliceBudget&, JS::gcreason::Reason) 	js/src/jsgc.cpp:6194
11 	xul.dll 	js::gc::GCRuntime::collect(bool, js::SliceBudget, JS::gcreason::Reason) 	js/src/jsgc.cpp:6305
12 	xul.dll 	js::gc::GCRuntime::gc(JSGCInvocationKind, JS::gcreason::Reason) 	js/src/jsgc.cpp:6373
13 	xul.dll 	mozilla::dom::workers::WorkerPrivate::GarbageCollectInternal(JSContext*, bool, bool) 	dom/workers/WorkerPrivate.cpp:6244
14 	xul.dll 	`anonymous namespace'::GarbageCollectRunnable::WorkerRun 	dom/workers/WorkerPrivate.cpp:1445
15 	xul.dll 	mozilla::dom::workers::WorkerRunnable::Run() 	dom/workers/WorkerRunnable.cpp:375
16 	xul.dll 	mozilla::dom::workers::WorkerPrivate::ProcessAllControlRunnablesLocked() 	dom/workers/WorkerPrivate.cpp:5047
17 	xul.dll 	mozilla::dom::workers::WorkerPrivate::DoRunLoop(JSContext*) 	dom/workers/WorkerPrivate.cpp:4460
18 	xul.dll 	`anonymous namespace'::WorkerThreadPrimaryRunnable::Run 	dom/workers/RuntimeService.cpp:2856
19 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1082
20 	xul.dll 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/glue/nsThreadUtils.cpp:290
21 	xul.dll 	mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:368
22 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:225
23 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:205
24 	xul.dll 	nsThread::ThreadFunc(void*) 	xpcom/threads/nsThread.cpp:465
25 	nss3.dll 	PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:397
26 	nss3.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:95
27 	ucrtbase.dll 	o__realloc_base 	
28 	kernel32.dll 	BaseThreadInitThunk 	
29 	ntdll.dll 	RtlUserThreadStart

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

According to Socorro record, this seems appear starting from ff52. Do you think about anything suspisions that might cause this?

Comment 2

[Andrea Marchesini [:baku]]

In theory, telemetry is thread-safe. I wonder if we have some issues here.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to alex_mayorga from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-f1db6841-0b51-4c1f-8c50-818d22161004.
> =============================================================
> 
> ¡Hola!
> 
> Recently crashed like this.
> 
> Guessing a component from the stack.
> 
> 27 other Nightly crashes in the past week at
> https://crash-stats.mozilla.com/signature/
> ?product=Firefox&signature=OOM%20%7C%20large%20%7C%20NS_ABORT_OOM%20%7C%20nsT
> Array_base%3CT%3E%3A%3AEnsureCapacity%3CT%3E%20%7C%20nsTArray_Impl%3CT%3E%3A%
> 3AAppendElement%3CT%3E%20%7C%20%60anonymous%20namespace%27%27%3A%3Ainternal_A
> ccumulate
> 
> ¡Gracias!
> Alex
> 
> Crashing Thread (32)
> Frame 	Module 	Signature 	Source
> 0 	xul.dll 	NS_ABORT_OOM(unsigned __int64) 	xpcom/base/nsDebugImpl.cpp:606
> 1 	xul.dll 	nsTArray_base<nsTArrayInfallibleAllocator,
> nsTArray_CopyWithMemutils>::
> EnsureCapacity<nsTArrayInfallibleAllocator>(unsigned __int64, unsigned
> __int64) 	obj-firefox/dist/include/nsTArray-inl.h:128
> 2 	xul.dll 	nsTArray_Impl<mozilla::dom::Element*,
> nsTArrayInfallibleAllocator>::AppendElement<mozilla::dom::Element*&,
> nsTArrayInfallibleAllocator>(mozilla::dom::Element*&) 
> obj-firefox/dist/include/nsTArray.h:2073
> 3 	xul.dll 	`anonymous namespace'::internal_Accumulate 
> toolkit/components/telemetry/TelemetryHistogram.cpp:1381

Hi :chutten, this crash happens since ff52. I wonder if there has somthing to do with bug 1218576 which touches TelemetryHistogram.cpp:1381.

Comment 4

[Chris H-C :chutten]

Oh yeah, this is almost certainly a dupe of bug 1304519, fixed 3 days after this report.