1307687 - Intermittent browser/base/content/test/urlbar/browser_urlbarTrimURLs.js | expected page should have loaded - Got about:blank, expected http://example.com/

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=4492985&repo=autoland

https://queue.taskcluster.net/v1/task/N6IBEKraSnevj0FeCTr8vg/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Marco Bonardo [:mak]]

this is similar to bug 1307676, it is using a custom load uri handler, while it should use BrowserTestUtils.browserLoaded

Comment 2

[Intermittent Failures Robot]

8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* autoland: 3
* fx-team: 1

Platform breakdown:
* linux64: 5
* osx-10-10: 2
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1307687&startday=2016-10-17&endday=2016-10-23&tree=all

Comment 3

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 2
* mozilla-beta: 1
* autoland: 1

Platform breakdown:
* linux64: 3
* windows7-32: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1307687&startday=2016-10-24&endday=2016-10-30&tree=all

Comment 4

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* mozilla-central: 2

Platform breakdown:
* windows7-32: 2
* linux64: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1307687&startday=2016-10-31&endday=2016-11-06&tree=all

Comment 5

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* autoland: 3
* try: 1

Platform breakdown:
* linux64: 4
* osx-10-10: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1307687&startday=2016-11-07&endday=2016-11-13&tree=all

Comment 6

[Marco Bonardo [:mak]]

let's just try to fix it, then.

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1307687 - Intermittent load failure in browser_urlbarTrimURLs.js.

Review commit: https://reviewboard.mozilla.org/r/93176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93176/

Comment 8

[:Gijs (he/him)]

Comment on attachment 8810893 [details]
Bug 1307687 - Intermittent load failure in browser_urlbarTrimURLs.js.

https://reviewboard.mozilla.org/r/93176/#review93154

::: browser/base/content/test/urlbar/browser_urlbarTrimURLs.js:1
(Diff revision 1)
> -/* Any copyright is dedicated to the Public Domain.
> +add_task(function* test() {

Nit: for my sanity, give this a better name or just get rid of it altogether. Then I don't need to remember if named function expressions create globals and thus conflict with using add_task or not. :-)

::: browser/base/content/test/urlbar/browser_urlbarTrimURLs.js:6
(Diff revision 1)
> -}
> -
> -function test() {
> -  const prefname = "browser.urlbar.trimURLs";
>  
> -  gBrowser.selectedTab = gBrowser.addTab();
> +  registerCleanupFunction(function* () {

Has someone actually task-ified `registerCleanupFunction` by now?

Comment 9

[Marco Bonardo [:mak]]

(In reply to :Gijs Kruitbosch (PTO Nov. 17-20 inclusive) from comment #8)
> > -  gBrowser.selectedTab = gBrowser.addTab();
> > +  registerCleanupFunction(function* () {
> 
> Has someone actually task-ified `registerCleanupFunction` by now?

what do you mean by task-ified? it accepts generator functions so far.

Comment 10

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #9)
> (In reply to :Gijs Kruitbosch (PTO Nov. 17-20 inclusive) from comment #8)
> > > -  gBrowser.selectedTab = gBrowser.addTab();
> > > +  registerCleanupFunction(function* () {
> > 
> > Has someone actually task-ified `registerCleanupFunction` by now?
> 
> what do you mean by task-ified? it accepts generator functions so far.

Does it treat them like generator functions instead of normal functions, though? It didn't use to... a lot of the customizableui tests have extra add_task() clauses in order to do async "cleanup" things.

Comment 11

[Marco Bonardo [:mak]]

it yields over the generator function, so it can either be a generator or return a promise. I think it's about 2 years that it works.

Comment 12

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #11)
> it yields over the generator function, so it can either be a generator or
> return a promise. I think it's about 2 years that it works.

Right, looks like bug 1000512 - the CUI tests are mostly older than when that got fixed. :-)

Comment 13

[Marco Bonardo [:mak]]

Comment on attachment 8810893 [details]
Bug 1307687 - Intermittent load failure in browser_urlbarTrimURLs.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93176/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aca647243c52
Intermittent load failure in browser_urlbarTrimURLs.js. r=Gijs

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aca647243c52

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ef846dd2617

Comment 17

[Intermittent Failures Robot]

5 failures in 715 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 3
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* linux64: 4
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1307687&startday=2016-11-14&endday=2016-11-20&tree=all