|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
We'll need to make stack capturing thread-safe. This probably means to have a dedicated mutex & locking around stack capture invocations & data access.
Looking over this, we already mostly protect the shared data in `KeyedStackCapturer`. KeyedStackCapturer::Capture() doesn't protect all the data accesses yet though.
Comment on attachment 8833370 [details] Bug 1307746: Make capturing stacks thread safe. https://reviewboard.mozilla.org/r/109622/#review111062
Hi Georg! I triggered a try build for this patch here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=176159b91df2&selectedJob=74796902 Some tests failed but they seem unrelated. For some reason I cannot re-trigger the jobs and cannot login either with LDAP or mozillian accounts. Can you re-trigger the tests that failed?
Those test failures look unrelated, i've triggered autoland.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d185a8dc4c45 Make capturing stacks thread safe. r=gfritzsche
Is this something that should go in 53 or is it going to ride the trains?
Not sure about that, but :gfritzsche should know what is best.
There is no code shipping in 53 that uses it, so there is no uplift needed.