Make stack capturing thread-safe

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: gfritzsche, Assigned: Iaroslav Sheptykin)

Tracking

(Blocks: 1 bug)

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 wontfix, firefox53 wontfix, firefox54 fixed)

Details

(Whiteboard: [measurement:client])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We'll need to make stack capturing thread-safe.
This probably means to have a dedicated mutex & locking around stack capture invocations & data access.
(Reporter)

Comment 1

9 months ago
Looking over this, we already mostly protect the shared data in `KeyedStackCapturer`.

KeyedStackCapturer::Capture() doesn't protect all the data accesses yet though.
Assignee: nobody → yarik.sheptykin
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8833370 [details]
Bug 1307746: Make capturing stacks thread safe.

https://reviewboard.mozilla.org/r/109622/#review111062
Attachment #8833370 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 4

8 months ago
Hi Georg!

I triggered a try build for this patch here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=176159b91df2&selectedJob=74796902

Some tests failed but they seem unrelated. For some reason I cannot re-trigger the jobs and cannot login either with LDAP or mozillian accounts. Can you re-trigger the tests that failed?
Flags: needinfo?(gfritzsche)
(Reporter)

Comment 5

8 months ago
Those test failures look unrelated, i've triggered autoland.
Flags: needinfo?(gfritzsche)

Comment 6

8 months ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/d185a8dc4c45
Make capturing stacks thread safe. r=gfritzsche

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d185a8dc4c45
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Is this something that should go in 53 or is it going to ride the trains?
status-firefox52: affected → wontfix
status-firefox53: --- → fix-optional
Flags: needinfo?(yarik.sheptykin)
(Assignee)

Comment 9

8 months ago
Not sure about that, but :gfritzsche should know what is best.
Flags: needinfo?(yarik.sheptykin) → needinfo?(gfritzsche)
(Reporter)

Comment 10

8 months ago
There is no code shipping in 53 that uses it, so there is no uplift needed.
status-firefox53: fix-optional → wontfix
Flags: needinfo?(gfritzsche)
You need to log in before you can comment on or make changes to this bug.