1307746 - Make stack capturing thread-safe

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Georg Fritzsche [:gfritzsche]]

We'll need to make stack capturing thread-safe.
This probably means to have a dedicated mutex & locking around stack capture invocations & data access.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Looking over this, we already mostly protect the shared data in `KeyedStackCapturer`.

KeyedStackCapturer::Capture() doesn't protect all the data accesses yet though.

Comment 2

[Iaroslav Sheptykin]

Attachment: Bug 1307746: Make capturing stacks thread safe.

Review commit: https://reviewboard.mozilla.org/r/109622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109622/

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8833370 [details]
Bug 1307746: Make capturing stacks thread safe.

https://reviewboard.mozilla.org/r/109622/#review111062

Comment 4

[Iaroslav Sheptykin]

Hi Georg!

I triggered a try build for this patch here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=176159b91df2&selectedJob=74796902

Some tests failed but they seem unrelated. For some reason I cannot re-trigger the jobs and cannot login either with LDAP or mozillian accounts. Can you re-trigger the tests that failed?

Comment 5

[Georg Fritzsche [:gfritzsche]]

Those test failures look unrelated, i've triggered autoland.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d185a8dc4c45
Make capturing stacks thread safe. r=gfritzsche

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d185a8dc4c45

Comment 8

[Julien Cristau [:jcristau]]

Is this something that should go in 53 or is it going to ride the trains?

Comment 9

[Iaroslav Sheptykin]

Not sure about that, but :gfritzsche should know what is best.

Comment 10

[Georg Fritzsche [:gfritzsche]]

There is no code shipping in 53 that uses it, so there is no uplift needed.