Implement a Developer Tools notification when changes are applied

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: denschub, Assigned: etsai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

3 years ago
We need a way to inform site developers (and WebCompat debuggers) that we've applied changes, like User Agent overrides.
Blocks: 1308271
No longer blocks: gofaster
Reporter

Comment 1

3 years ago
Implement a "The user agent has been overridden for compatibility reasons. [learn more]" with a link to the webcompat.com/bugzilla report.

Also, we need to figure out if it's possible to add two links: one for the actual report, one to instructions on how to disable that.
Base on the description in https://developer.mozilla.org/zh-TW/docs/Tools/Web_Console/Custom_output to implement a patch for notification.
QA Contact: etsai
Assignee: nobody → etsai
QA Contact: etsai
Hi Dennis, this is my working patch for DevTool implement. Learn more is not possible but we can customize to enrich the notification.
Attachment #8806262 - Flags: review?(dschubert)
Reporter

Comment 4

3 years ago
Comment on attachment 8806262 [details] [review]
WIP for Implement DevTool notification

There seems to be no better way than the webextension solution Eric built at the moment. I am still working on getting information about what exactly needs to be implemented in Gecko for us to be able to do nicer logging, but let's not block on that.

Cancelling the review because of the style issues, but the general approach seems to be r+'ish.
Attachment #8806262 - Flags: review?(dschubert) → review-
Reporter

Comment 5

3 years ago
Comment on attachment 8806262 [details] [review]
WIP for Implement DevTool notification

I intended to cancel the review, not r- it. Sorry.
Attachment #8806262 - Flags: review-
Comment on attachment 8806262 [details] [review]
WIP for Implement DevTool notification

Fix most eslint style and host permission to <all_urls>
Attachment #8806262 - Flags: review?(dschubert)
Reporter

Comment 7

3 years ago
Comment on attachment 8806262 [details] [review]
WIP for Implement DevTool notification

r+! We're going to have a chat about possible follow-ups soon'ish, but this is great for now. Thanks for your work, Eric. :)
Attachment #8806262 - Flags: review?(dschubert) → review+
Reporter

Comment 8

3 years ago
Eric, could you please rebase on latest master?
Reporter

Updated

3 years ago
See Also: → 1316668
Reporter

Comment 9

3 years ago
I've merged this and opened bug 1316668 as a follow-up for improvements we should do in version 2! Thanks again, Eric!
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.