Closed Bug 1307885 Opened 9 years ago Closed 8 years ago

Test prepareMessage

Categories

(DevTools :: Console, enhancement)

Product:
DevTools
Component:
Console
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: linclark, Unassigned)

References

Details

Originally posted by:linclark see https://github.com/devtools-html/gecko-dev/issues/152 We can test `prepareMessage` pretty easily by stubbing out the `ConsoleMessage`s that we expect for each line of input. This means that we can have confidence in the API that `ConsoleMessage` provides. This is great because it means we could remove all of the packet fetching from the component tests.
Priority: -- → P2
Whiteboard: new-console
Blocks: enable-new-console
Flags: qe-verify-
Priority: P2 → P3
Whiteboard: new-console → [reserve-new-console]
Whiteboard: [reserve-new-console] → [reserve-console-html]
Priority: P3 → P4
Flags: qe-verify-
Priority: P4 → P2
Whiteboard: [reserve-console-html] → [newconsole-mvp]
I started working on this, but felt like it is redundant with all the other mocha test we have + our stub generation setup. Brian, what do you think of closing this (or at least removing it from the mvp) ? The only thing would be able to test cached messages, but I'd rather do this by generating cached packet in stubs and compare the resulting message against a "live" packet message.
Flags: needinfo?(bgrinstead)
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1) > I started working on this, but felt like it is redundant with all the other > mocha test we have + our stub generation setup. > Brian, what do you think of closing this (or at least removing it from the > mvp) ? > The only thing would be able to test cached messages, but I'd rather do this > by generating cached packet in stubs and compare the resulting message > against a "live" packet message. Yeah, let's close this.
Flags: needinfo?(bgrinstead)
Status: NEW → RESOLVED
Closed: 8 years ago
Priority: P2 → --
Resolution: --- → INVALID
Whiteboard: [newconsole-mvp]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.