1307922 - Add support for console.dir()

Status: VERIFIED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/221

Tests:

- [ ] browser_bug_862916_console_dir_and_filter_off.js
- [ ] browser_webconsole_bug_659907_console_dir.js

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This shows an inline variable view with all the properties of the object passed as a parameter.
Since we're gonna switch to object inspection, I wonder if we can wait till we have them (we would then "only" have to open the first level).

Comment 2

[Lin Clark [:linclark]]

I think postponing this until we have object inspection makes sense.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1307922 - Add support for console.dir();

Review commit: https://reviewboard.mozilla.org/r/156010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156010/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

My patch won't work until Bug 1308566 lands, but I think it is ready for review.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8885151 [details]
Bug 1307922 - Add support for console.dir();

https://reviewboard.mozilla.org/r/156010/#review161240

The impl looks super simple!

The only problem is the test, it fails for me (Win10)

26 INFO TEST-UNEXPECTED-FAIL | devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_dir.js | Uncaught exception - waitFor - threw exception: TypeError: node is undefined

Honza

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Comment on attachment 8885151 [details]
> Bug 1307922 - Add support for console.dir();
> 
> The only problem is the test, it fails for me (Win10)

It might be because this is built on top of the in-review Bug 1308566 patch, which isn't included here when you pull the patch.
I'll rebase this patch when the OI patch lands and will ask for review again so you can check the test.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8885151 [details]
Bug 1307922 - Add support for console.dir();

https://reviewboard.mozilla.org/r/156010/#review161578

I tried again on the latest m-c (UI landed) and the test works for me.

Thanks for working on this!

Honza

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8885151 [details]
Bug 1307922 - Add support for console.dir();

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156010/diff/1-2/

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Thanks Honza. I rebased and pushed to TRY, let's see if everything is okay.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8885151 [details]
Bug 1307922 - Add support for console.dir();

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156010/diff/2-3/

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8885151 [details]
Bug 1307922 - Add support for console.dir();

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156010/diff/3-4/

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

I fixed the ESLint issues. Let's push this

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae87679e5f8d
Add support for console.dir(); r=Honza

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae87679e5f8d

Comment 15

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I can confirm the bug is verified fixed on latest Nightly 56.0a1 (2017-07-17), using Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6.