1307936 - Reset filter prefs in between tests

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Lin Clark [:linclark]]

Originally posted by:bgrins

see https://github.com/devtools-html/gecko-dev/issues/332

Right now we don't clean up filtering after browser_webconsole_filters.js finishes, so the error filter is off for the rest of the tests.  This'll eventually cause a problem, so we should make sure to reset it in a cleanup function in our head.js file

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1307936 - Reset filter prefs in between console mochitests;

Review commit: https://reviewboard.mozilla.org/r/140820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140820/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8869256 [details]
Bug 1307936 - Reset filter prefs in between console mochitests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140820/diff/1-2/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8869256 [details]
Bug 1307936 - Reset filter prefs in between console mochitests;

https://reviewboard.mozilla.org/r/140820/#review145392

Looks reasonable to me, thanks!

Btw. rebase needed.

Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:25
(Diff revision 2)
>  
>  Services.prefs.setBoolPref("devtools.webconsole.new-frontend-enabled", true);
>  registerCleanupFunction(function* () {
>    Services.prefs.clearUserPref("devtools.webconsole.new-frontend-enabled");
>  
> +  // Reset all filter prefs between tests.  First flushPrefEnv in case one of the

nit: two spaces between `tests.` and `First`

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8869256 [details]
Bug 1307936 - Reset filter prefs in between console mochitests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140820/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c39826d3493f
Reset filter prefs in between console mochitests;r=Honza

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c39826d3493f