1307947 - Improve network event update stub generation

Status: RESOLVED INVALID

(DevTools :: Console, enhancement)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/312

Network event update stubs are hard to generate. We have a good start in place in #283, but there are a couple of flaws still.

1. It's hard to come up with a unique name for update stubs. Currently we do a pretty good job, but there are still places where we use the same key for multiple stubs.
2. It's hard to determine how many packets we should listen for. Currently it's hardcoded to 8, but that number could easily change on the backend. Perhaps we should listen for a set amount of time in the stub generator instead.
3. Because the object being sent from the client is mutated in the client when new packets come in, it's likely that the stubs for certain messages are inaccurate... the object will have been mutated before we write it. We could potentially solve this by changing the client. In the client, we could break out the code that formats the packet in `_onNetworkEvent`/`_onNetworkEventUpdate`. Then it could be reused in the test. Eventually, I think we might want to rearrange the client so that it doesn't handle this at all, but that will impact net monitor so will require more planning.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

We don't have issues with network update stubs anymore