1307954 - Add e2e test for clicking on network event message url

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/269

Follow up for #195 

We can't unit test this easily, so should have an e2e test to cover it.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1307954 - Add integration test for clicking on network event message url; .

This ensures that clicking on a message open the netmonitor panel, with the network
item clicked being selected in the netmonitor panel.
The loadDocument was edited to accept a URL instead of relying on the existence of
a TEST_PATH variable. Callsites where thus modified.

Review commit: https://reviewboard.mozilla.org/r/150848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150848/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8879546 [details]
Bug 1307954 - Add integration test for clicking on network event message url; .

https://reviewboard.mozilla.org/r/150848/#review156174

Looks reasonable!

R+

Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0bd396cd081
Add integration test for clicking on network event message url; r=Honza.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0bd396cd081