Closed
Bug 1307995
Opened 9 years ago
Closed 9 years ago
Drop Belarusian (be) from Firefox for Android in both maemo-locales and all-locales. Add Nepali (ne-NP), Bulgarian (bg) and Kabyle (kab) to all-locales
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(relnote-firefox 51+, firefox51 fixed)
RESOLVED
FIXED
People
(Reporter: delphine, Assigned: delphine)
References
Details
Attachments
(1 file)
|
952 bytes,
patch
|
flod
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As commented by :flod in Bug 1304743, Belarusian hasn't see any activity in almost 2 years. We will want to drop it from both maemo-locales and all-locales.
| Assignee | ||
Updated•9 years ago
|
Assignee: mozilla_by → lebedel.delphine
| Assignee | ||
Comment 1•9 years ago
|
||
For the sake of simplicity, changing the title of this bug to work on multiple locales here. We will also want to add Kabyle (kab), Bulgarian (bg) and Nepali (ne-NP) to single-locale builds.
Summary: Drop Belarusian (be) from Firefox for Android in both maemo-locales and all-locales → Drop Belarusian (be) from Firefox for Android in both maemo-locales and all-locales. Add Nepali (ne-NP), Bulgarian (bg) and Kabyle (kab) to single-locales
| Assignee | ||
Updated•9 years ago
|
Summary: Drop Belarusian (be) from Firefox for Android in both maemo-locales and all-locales. Add Nepali (ne-NP), Bulgarian (bg) and Kabyle (kab) to single-locales → Drop Belarusian (be) from Firefox for Android in both maemo-locales and all-locales. Add Nepali (ne-NP), Bulgarian (bg) and Kabyle (kab) to all-locales
| Assignee | ||
Comment 2•9 years ago
|
||
bg and kab are new Fennec locales. Please add to dashboards
| Assignee | ||
Updated•9 years ago
|
Blocks: fm-l10n-kab
| Assignee | ||
Updated•9 years ago
|
Blocks: fm-l10n-bg
| Assignee | ||
Updated•9 years ago
|
Blocks: fm-l10n-ne-NP
| Assignee | ||
Comment 3•9 years ago
|
||
My comment above about dashboards is wrong, I forgot one locale. Please add bg, ne-NP and kab to dashboards as they are new fennec locales. Please drop be from dashboards. thanks (and sorry for all this noise...)
Attachment #8800461 -
Flags: review?(francesco.lodolo)
Comment 4•9 years ago
|
||
Comment on attachment 8800461 [details] [diff] [review]
bug1307995.patch
Review of attachment 8800461 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
I'm pretty sure dashboards will get the locales automatically as soon as this lands in mozilla-aurora.
Attachment #8800461 -
Flags: review?(francesco.lodolo) → review+
Comment 5•9 years ago
|
||
Correction: On the other hand, we'll need to NI Pike to remove Belarusian from the dashboard when this lands. I'll leave setting flags to you for the attachments ;-)
Comment 6•9 years ago
|
||
Moving over to Fx Android Build Config, as that is what this bug is about now.
Component: be / Belarusian → Build Config & IDE Support
Product: Mozilla Localizations → Firefox for Android
| Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8800461 [details] [diff] [review]
bug1307995.patch
This is a change that needs to land only in Mozilla Aurora.
Also for relnotes: this adds 3 locales (ne-NP, bg and kab) and drops one (be)
Attachment #8800461 -
Flags: approval-mozilla-aurora?
| Assignee | ||
Comment 8•9 years ago
|
||
I'm sorry, for the added locales we don't need relnotes since they are added to single-locale builds! However since be locale is dropped from maemo-locales, this should probably be renoted. Thanks!
| Assignee | ||
Updated•9 years ago
|
relnote-firefox:
--- → ?
Updated•9 years ago
|
status-firefox51:
--- → affected
Comment 9•9 years ago
|
||
Comment on attachment 8800461 [details] [diff] [review]
bug1307995.patch
Locale changes. Take it in 51 aurora.
Attachment #8800461 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
| bugherder uplift | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•8 years ago
|
||
This is included in https://www.mozilla.org/en-US/firefox/android/51.0beta/releasenotes/
Updated•6 years ago
|
Product: Firefox for Android → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•