Closed
Bug 1308008
Opened 8 years ago
Closed 8 years ago
Defects revealed by Coverity scan
Categories
(JSS Graveyard :: Library, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.4
People
(Reporter: elio.maldonado.batiz, Assigned: jmagne)
References
Details
Attachments
(1 file, 6 obsolete files)
|
12.73 KB,
patch
|
mharmsen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•8 years ago
|
||
Downstream patch by John Magne, not ready yet for review.
|
|
Reporter | |
Comment 2•8 years ago
|
||
Upated for current sources, all test pass (30 out 30)
|
|
Reporter | |
Updated•8 years ago
|
Assignee: glenbeasley → jmagne
|
|
Reporter | |
Comment 3•8 years ago
|
||
These patches may need to be supplemented with one from Bug 1307993 that we decided to postpone until we reach this one, see https://bug1307993.bmoattachments.org/attachment.cgi?id=8839295
|
|
Reporter | |
Comment 4•8 years ago
|
||
My bad, these comments where meant for Bug 1308004 instead.
|
|
Reporter | |
Comment 5•8 years ago
|
||
Attachment #8798950 -
Attachment is obsolete: true
Attachment #8835165 -
Attachment is obsolete: true
Attachment #8840971 -
Flags: review?(jmagne)
Attachment #8840971 -
Flags: review?(jmagne) → review?(mharmsen)
|
|
Reporter | |
Comment 6•8 years ago
|
||
This version is a lot closer to the original. I found that previous version had a lot of missing pieces when comparing against the original and this one should fix that.
Attachment #8840971 -
Attachment is obsolete: true
Attachment #8840971 -
Flags: review?(mharmsen)
Attachment #8842081 -
Flags: review?(mharmsen)
|
|
Reporter | |
Comment 7•8 years ago
|
||
Add another portion that was still missing. Comparing with meld against the original will take you some time as plenty has changed upstream since then.
Attachment #8842081 -
Attachment is obsolete: true
Attachment #8842081 -
Flags: review?(mharmsen)
Attachment #8842145 -
Flags: review?(mharmsen)
|
|
Reporter | |
Comment 8•8 years ago
|
||
I stated earlier that meld compares with original would take some time and care and I wasn't wrong. This one should be what I intended.
Attachment #8842145 -
Attachment is obsolete: true
Attachment #8842145 -
Flags: review?(mharmsen)
Attachment #8842165 -
Flags: review?(mharmsen)
|
||
Updated•8 years ago
|
Attachment #8842165 -
Flags: review?(mharmsen) → review+
|
|
Reporter | |
Comment 9•8 years ago
|
||
Attachment #8842165 -
Attachment is obsolete: true
Attachment #8842643 -
Flags: review?(mharmsen)
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8842643 [details] [diff] [review]
eliminate native coverity defects
ACK
Attachment #8842643 -
Flags: review?(mharmsen) → review+
|
|
Reporter | |
Comment 11•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 12•8 years ago
|
||
Historical Note:
# RHBZ 715621 - Defects revealed by Coverity scan (Matt)
# https://bugzilla.redhat.com/show_bug.cgi?id=715621
# author: mharmsen@redhat.com
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1308008
Patch16: jss-eliminate-native-coverity-defects.patch
|
|
Reporter | |
Updated•8 years ago
|
Target Milestone: --- → 4.4
You need to log in
before you can comment on or make changes to this bug.
Description
•