Closed Bug 1308105 Opened 9 years ago Closed 4 years ago

Replace PL_strpbrk with strpbrk

Categories

(Core :: XPCOM, defect, P5)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: cpeterson, Assigned: smurfd)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=c++])

Attachments

(1 file)

We should replace NSPR functions with standard C functions when they available on all platforms. 1. Replace PL_strpbrk() calls with strpbrk(): http://searchfox.org/mozilla-central/search?q=%5CbPL_strn%3Fpr%3Fbrk%5Cb&regexp=true&path=.cpp%24 *** CAUTION: PL_strpbrk() will return without crashing when passed a null pointer, but strpbrk() will crash! Any calls to PL_strpbrk() that are changed should be audited to see if they might need to handle a null pointer. 2. Add #include <string.h> if it's needed for strpbrk()'s function declaration. 3. Remove #include "plstr.h" if it's no longer needed for other NSPR string function declarations.
Mentor: cpeterson
Mentor: cpeterson
Component: General → String
Component: String → XPCOM
Assignee: nobody → smurfd
Attachment #9225422 - Attachment description: WIP: Bug 1308105 - Replace PL_strpbrk with strpbrk → Bug 1308105 - Replace PL_strpbrk with strpbrk
Status: NEW → ASSIGNED
Attachment #9225422 - Attachment description: Bug 1308105 - Replace PL_strpbrk with strpbrk → WIP: Bug 1308105 - Replace PL_strpbrk with strpbrk
Blocks: 1724649
Attachment #9225422 - Attachment description: WIP: Bug 1308105 - Replace PL_strpbrk with strpbrk → Bug 1308105 - Replace PL_strpbrk with strpbrk
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4844183d0b44 Replace PL_strpbrk with strpbrk r=xpcom-reviewers,kmag
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: