Create Carthage dependency wrapper around page-metadata-parser instead of directly pulling in JS library

RESOLVED FIXED

Status

()

Firefox for iOS
General
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MobileAS])

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Originally the branch I had for setting up the page-metadata-parser code in iOS had the bundled JS file included in the repo. With the recent changes to the PR I had open [1] to get it merged into master, we no longer have it committed in git. In order to properly import the library into Firefox for iOS one option is to create a new carthage dependency that wraps around the JS library and has the script bundling as part of the build phases. This also gives us the option to abstract out the parsing code from the JS if we plan on using a server-side service or alternative client code.

Unfortunately since the PR has been merged and updated, new clean checkouts using Carthage will result in build errors in Firefox for iOS because the bundle file is missing. Since this can effect building the project now, I'm going to move this into this sprint/P1 so we can avoid any build issues from contributors.

[1] https://github.com/mozilla/page-metadata-parser/pull/68
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8799879 [details] [review]
Github PR

Instead of sinking time into getting the Carthage dependency up right now, I've committed the JS bundle directly into the repo temporarily until we can get a Carthage dependency up and running for it.
Attachment #8799879 - Flags: review?(bnicholson)
Attachment #8799879 - Flags: review?(bnicholson) → review+

Updated

2 years ago
Priority: P1 → P3
(Assignee)

Comment 3

2 years ago
Moving to P2 as this should be something we do before we ship AS with metadata parsing.
Priority: P3 → P2

Updated

2 years ago
Priority: P2 → P1
(Assignee)

Updated

2 years ago
Blocks: 1311081

Updated

2 years ago
Iteration: --- → 1.7
(Assignee)

Comment 4

2 years ago
Created attachment 8804007 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2189
Attachment #8804007 - Flags: review?(bnicholson)
(Assignee)

Comment 5

2 years ago
Created attachment 8804008 [details]
WebMetadataKit Library

The library
Attachment #8804008 - Flags: feedback?(bnicholson)
Comment on attachment 8804007 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2189

Makes sense to me!
Attachment #8804007 - Flags: review?(bnicholson) → review+
Attachment #8804008 - Flags: feedback?(bnicholson) → feedback+
(Assignee)

Comment 7

2 years ago
master https://github.com/mozilla-mobile/firefox-ios/commit/1d083b62ef9a5d233819170959a515c7546fcba9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.