1308233 - Assertion failure: popupAnchor == 2, at /builds/moz2/working/layout/xul/nsMenuPopupFrame.cpp

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: Fix assertion for rtl

Steps:

1. Use a debug nightly RTL build (or set the RTL preference)
2. Open any dropdown in preference

Get the assertion and the popup doesn't open.

Regression from 52106.

Comment 1

[Neil Deakin]

Attachment: Fix assertion for rtl

Comment 2

[Neil Deakin]

Comment on attachment 8798462 [details] [diff] [review]
Fix assertion for rtl

This fixes a assertion in rtl caused by the menulist opening with its selected item in position change.

Comment 3

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46f84dd5c793ca20efa23c7bd727050004ab1f7d
Bug 1308233, fix assertion opening menulists in rtl, r=mstange

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46f84dd5c793

Comment 5

[Neil Deakin]

Comment on attachment 8798462 [details] [diff] [review]
Fix assertion for rtl

Approval Request Comment
[Feature/regressing bug #]: 52106
[User impact if declined]: debug RTL users will assert/crash when a dropdown in chrome UI (preferences/bookmarks/etc) is opened
[Describe test coverage new/current, TreeHerder]: manual testing, fixes assert line
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8798462 [details] [diff] [review]
Fix assertion for rtl

Fix an assertion. Take it in 51 aurora.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f88a13f533e0