1308385 - "toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name" with --disable-crashreporter

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name
mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C3861: 'AnnotateCrashReport': identifier not found

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: add a MOZ_CRASHREPORTER ifdef in the appropriate place

This fixes it for me.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8798709 [details] [diff] [review]
add a MOZ_CRASHREPORTER ifdef in the appropriate place

Review of attachment 8798709 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you compiled this locally --disable-crashreporter and didn't get any warnings for cpuUpdateRevision being unused, r=me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c560d4ed804
Make sure CrashReporter::AnnotateCrashReport usage is guarded by MOZ_CRASHREPORTER in nsAppRunner.cpp. r=froydnj

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c560d4ed804