Closed Bug 1308385 Opened 5 years ago Closed 5 years ago

"toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name" with --disable-crashreporter

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name
mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C3861: 'AnnotateCrashReport': identifier not found
This fixes it for me.
Attachment #8798709 - Flags: review?(ted)
Comment on attachment 8798709 [details] [diff] [review]
add a MOZ_CRASHREPORTER ifdef in the appropriate place

Review of attachment 8798709 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you compiled this locally --disable-crashreporter and didn't get any warnings for cpuUpdateRevision being unused, r=me.
Attachment #8798709 - Flags: review?(ted) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c560d4ed804
Make sure CrashReporter::AnnotateCrashReport usage is guarded by MOZ_CRASHREPORTER in nsAppRunner.cpp. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/3c560d4ed804
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.