"toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name" with --disable-crashreporter

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C2653: 'CrashReporter': is not a class or namespace name
mozilla-central/toolkit/xre/nsAppRunner.cpp(3449): error C3861: 'AnnotateCrashReport': identifier not found
(Assignee)

Comment 1

2 years ago
Created attachment 8798709 [details] [diff] [review]
add a MOZ_CRASHREPORTER ifdef in the appropriate place

This fixes it for me.
Attachment #8798709 - Flags: review?(ted)
Comment on attachment 8798709 [details] [diff] [review]
add a MOZ_CRASHREPORTER ifdef in the appropriate place

Review of attachment 8798709 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you compiled this locally --disable-crashreporter and didn't get any warnings for cpuUpdateRevision being unused, r=me.
Attachment #8798709 - Flags: review?(ted) → review+

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c560d4ed804
Make sure CrashReporter::AnnotateCrashReport usage is guarded by MOZ_CRASHREPORTER in nsAppRunner.cpp. r=froydnj
(Assignee)

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c560d4ed804
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.