1308405 - Reduce the number of Java objects created for out-of-process decoders.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[John Lin [:jhlin][:jolin]]

Currently we pass |Sample| object in some |ICodec| and |ICodecCallback| methods and huge amount of short lived objects are generated by AIDL generated code, therefore more GC.
The idea is to add |get(Input|Output)Buffer(int index)| methods and pass only index in |*Buffer()| methods, and a list of |Sample| objects can by maintained in |CodecProxy|.

Comment 1

[John Lin [:jhlin][:jolin]]

Fixing this could be very helpful to reduce the frames dropped on Fire TV Cube. See bug 1529486 comment 15.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

John Lin is working on a patch for this

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1308405 - p1: Recycle input buffer info. r?jya!

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1308405 - p2: Nodify and recycle sample objects. r?snorp!

Depends on D24587

Comment 5

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1308405 - p3: Use sample buffer class directly. r?snorp!

Depends on D24588

Comment 6

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1308405 - p4: Separate buffer from sample object. r?jya!,snorp!

To prevent new buffer object from being created per frame, either
Sample.CREATOR has to keep track of all buffers from every remote codec,
or the client must memorize seen buffers and avoid asking for them again
and again. The former saves client code from modifications but complicates
the implementation of Sample, a data structure class, while the latter
requires changes to client code but avoid overcomplicating Sample.CREATOR
implementation.

The 2nd approach is taken:

• move SampleBuffer out of Sample, and update clients accordingly
• add a new IPC method for clients to get the buffers only when needed

Depends on D24589

Comment 7

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1308405 - p5: Memorize sample buffers in CodecProxy. r?snorp!

Depends on D24590

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbb7c0704a08
p1: Recycle input buffer info. r=jya
https://hg.mozilla.org/integration/autoland/rev/9a095e082820
p2: Nodify and recycle sample objects. r=snorp
https://hg.mozilla.org/integration/autoland/rev/e9985b6b2769
p3: Use sample buffer class directly. r=snorp
https://hg.mozilla.org/integration/autoland/rev/f3367091fba8
p4: Separate buffer from sample object. r=snorp
https://hg.mozilla.org/integration/autoland/rev/78909d4b2ed3
p5: Memorize sample buffers in CodecProxy. r=snorp

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dbb7c0704a08
https://hg.mozilla.org/mozilla-central/rev/9a095e082820
https://hg.mozilla.org/mozilla-central/rev/e9985b6b2769
https://hg.mozilla.org/mozilla-central/rev/f3367091fba8
https://hg.mozilla.org/mozilla-central/rev/78909d4b2ed3

Comment 10

[Chris Peterson [:cpeterson]]

67=fix-optional. Neither Fenix MVP nor Firefox for Fire TV will use GeckoView 67, so we don't need to uplift this fix to 67 Beta unless you want it in Fennec 67.