1308447 - Use mozStorageConnectionUtils and IncrementalVacuumConnection in dom/cache

Status: NEW

(Core :: DOM: Service Workers, defect, P3)

Description

[Fernando Jiménez Moreno [:ferjm]]

Bug 1217544 moves storage related code shared by dom/cache and dom/backgroundsync to storage/mozStorageConnectionUtils* and storage/IncrementalVacuumConnection*. This bug is to make use of this shared code in dom/cache.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfcef9c234fb

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64a209ead135

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcebc3bb850f

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb1bf530e35b

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6eec0566e752

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d1ea1d328fe

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9f172fe9d95

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6718acc257f9

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=665ab9ff6f01

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59e4be05e63b

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2131c6a2ca38

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=194d0266252c

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bf9a2692d3f

Comment 15

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60ee3ed96558

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d647d0113f9

Comment 17

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ff7cfaa19bf

Comment 18

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fadaa78105c

Comment 19

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2533bc01797

Comment 20

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 21

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85f20acc0761

Comment 22

[Fernando Jiménez Moreno [:ferjm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dae270c559a

Comment 23

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8832160 [details] [diff] [review]
v1

Review of attachment 8832160 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  r=me with comments addressed.

::: dom/cache/DBSchema.cpp
@@ +388,5 @@
>  {
>    MOZ_ASSERT(!NS_IsMainThread());
>    MOZ_DIAGNOSTIC_ASSERT(aConn);
>  
> +  nsTArray<nsCString> tablesSql;

These can be AutoTArray<> with the correct number of expected elements.

::: dom/cache/DBSchema.h
@@ +126,5 @@
> +// Grow the database in chunks to reduce fragmentation
> +const uint32_t kGrowthSize = 32 * 1024;
> +const uint32_t kGrowthPages = kGrowthSize / kPageSize;
> +static_assert(kGrowthSize % kPageSize == 0,
> +              "Growth size must be multiple of page size");

Why is this stuff in the header?  It seems like it should live in DBSchema.cpp.  AFAICT only kMaxFreePages is used in another file.