1308490 - Move filtering functions to their own module

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

netmonitor-view.js contains filtering functions like isHtml or isImage. We should:

- Move them to a filter-predicates.js module.

Comment 1

[Jarda Snajdr [:jsnajdr]]

Attachment: Bug 1308490 - Move filtering functions to their own module

Review commit: https://reviewboard.mozilla.org/r/84536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84536/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8799324 [details]
Bug 1308490 - Move filtering functions to their own module

https://reviewboard.mozilla.org/r/84536/#review83134

Looks good, R+ assuming tests are green.

Honza

Comment 3

[Jarda Snajdr [:jsnajdr]]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> Looks good, R+ assuming tests are green.

Thanks! Try run is in progress here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bf08eb1808d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53a3a1d855e9
Move filtering functions to their own module r=Honza

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/53a3a1d855e9